Bug 139720 - shells/bash: fix $() parsing
shells/bash: fix $() parsing
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: obrien
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-18 15:10 UTC by Christian Weisgerber
Modified: 2009-11-02 18:40 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (665 bytes, patch)
2009-10-18 15:10 UTC, Christian Weisgerber
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Weisgerber freebsd_committer 2009-10-18 15:10:02 UTC
$() parsing is still broken in bash 4.0.33 as installed by the port.

We need to pass the -y flag to bison.  Plain "bison -d parse.y"
outputs parse.tab.c instead of y.tab.c, so y.tab.c is never
regenerated, and the parser fix from patch 001 is effectively not
applied.

[Resent as PR so it doesn't get lost again.]

How-To-Repeat: 
bash -c 'echo $(echo \|)'
Comment 1 Edwin Groothuis freebsd_committer 2009-10-18 15:10:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->obrien

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter freebsd_committer 2009-11-02 18:29:08 UTC
naddy       2009-11-02 18:28:59 UTC

  FreeBSD ports repository

  Modified files:
    shells/bash          Makefile 
  Log:
  Pass the -y flag to bison to fix $() parsing.
  Plain "bison -d parse.y" outputs parse.tab.c instead of y.tab.c,
  so y.tab.c is never regenerated, and the parser fix from patch 001
  is effectively not applied.
  
  PR:             139720
  Approved by:    maintainer timeout (4+2 weeks)
  
  Revision  Changes    Path
  1.117     +2 -2      ports/shells/bash/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Christian Weisgerber freebsd_committer 2009-11-02 18:29:21 UTC
State Changed
From-To: open->closed

Committed.  The PR has been open for two weeks and I originally mailed 
obrien@ on Sep 21.