Bug 140364 - [patch] ports-mgmt/portupgrade-devel: #! line substitution is broken
Summary: [patch] ports-mgmt/portupgrade-devel: #! line substitution is broken
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-07 18:10 UTC by Akinori MUSHA
Modified: 2012-04-18 19:05 UTC (History)
0 users

See Also:


Attachments
file.diff (497 bytes, patch)
2009-11-07 18:10 UTC, Akinori MUSHA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Akinori MUSHA freebsd_committer freebsd_triage 2009-11-07 18:10:02 UTC
  #! line substitution in portupgrade-devel is broken.

Fix: sub() is not equivalent to $_.sub() but $_.sub!().

  Just back out the modification as follows:

Or use the destructive method:



-- 
Akinori MUSHA / http://akinori.org/--rvgumNo9UPMhUAosdCWJVUZFyDupUN1dD7mpgDPErH6CUs3E
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- bin/Makefile.orig   2008-07-17 09:26:38.000000000 +0900
+++ bin/Makefile        2009-11-08 02:31:36.000000000 +0900
@@ -28,7 +28,7 @@ ${script}: ${script:T}
   ${RUBY} -pe ' \
           if $$. == 1; \
               if /^#!/; \
-                   $$_.sub(/^#!\s*\S*(\benv\s+)?\bruby/, "#!${RUBY}"); \
+                   sub /^#!\s*\S*(\benv\s+)?\bruby/, "#!${RUBY}"; \
                 else; \
                         $$_ = "#!${RUBY}\n" + $$_; \
                              end; \
How-To-Repeat: 
  Install portupgrade-devel and run `head -n1 /usr/local/sbin/portupgrade'.
  If it shows `#!/usr/bin/env ruby', the line has not been properly processed.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-11-07 18:10:38 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ruby

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Philip M. Gollucci freebsd_committer freebsd_triage 2010-09-10 00:11:53 UTC
Responsible Changed
From-To: ruby->pgollucci

I will take it
Comment 3 Philip M. Gollucci freebsd_committer freebsd_triage 2010-09-24 07:22:46 UTC
Responsible Changed
From-To: pgollucci->freebsd-ports-bugs

going to have enotime for the next 2 weeks, sorry
Comment 4 Steve Price freebsd_committer freebsd_triage 2011-01-03 17:20:42 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ruby

Over to maintainer(s).
Comment 5 Philip M. Gollucci freebsd_committer freebsd_triage 2012-02-22 05:23:56 UTC
State Changed
From-To: open->suspended

Over to maintainer. 


Comment 6 Philip M. Gollucci freebsd_committer freebsd_triage 2012-02-22 05:23:56 UTC
Responsible Changed
From-To: ruby->freebsd-ports-bugs

Over to maintainer.
Comment 7 Chris Rees freebsd_committer freebsd_triage 2012-04-12 11:03:04 UTC
State Changed
From-To: suspended->open

This should not be suspended.
Comment 8 Bryan Drewery 2012-04-18 18:57:35 UTC
This was fixed in 2.4.9.3. Released (port) Aug 23 2011.

Thanks,
Bryan Drewery (current maintainer)

Comment 9 Chris Rees freebsd_committer freebsd_triage 2012-04-18 19:05:55 UTC
State Changed
From-To: open->closed

Fixed in upstream. 


Comment 10 Chris Rees freebsd_committer freebsd_triage 2012-04-18 19:05:55 UTC
Responsible Changed
From-To: freebsd-ports-bugs->crees

Fixed in upstream.