Bug 140855 - astro/gpstk: reading dual frequency NovaTel data, buffer overflow
Summary: astro/gpstk: reading dual frequency NovaTel data, buffer overflow
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-25 03:10 UTC by freebsd
Modified: 2009-11-28 15:14 UTC (History)
1 user (show)

See Also:


Attachments
patch.shar (2.30 KB, text/plain)
2009-11-25 04:03 UTC, freebsd
no flags Details
patch.shar (2.30 KB, text/plain)
2009-11-25 04:09 UTC, c.thomson
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description freebsd 2009-11-25 03:10:04 UTC
Reading dual frequency NovaTel OEM4 range data fails when number of SV's >=12 due
to insufficient buffer size.
ie. Two range records (L1 & L2) are produced for each SV which exceeds buffer allocated for 
12 SV

Fix: 

Increased size of buffer in NovatelData.hpp
Used sizeof and corrected determining if a buffer overrun will occur for OEM2 and
OEM4 receivers in NovatelData.cpp.

Patch files attached.

This patch should also work with gpstk v1.6
How-To-Repeat: 
Turn on debug in NovatelData.cpp, recompile and read appropriate data file with novaRINEX.
Comment 1 freebsd 2009-11-25 04:03:40 UTC
Patch files not listed in Fix:

Please find shar file attached
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2009-11-25 04:07:32 UTC
State Changed
From-To: open->feedback

Fix synopsis and ask for patch.  (One was not included.)
Comment 3 c.thomson 2009-11-25 04:09:07 UTC
Patch files not listed in Fix:

Please find shar file attached
Comment 4 Edwin Groothuis freebsd_committer 2009-11-25 20:56:50 UTC
State Changed
From-To: feedback->open

Patches received
Comment 5 Dmitry Marakasov freebsd_committer 2009-11-28 02:47:59 UTC
Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it.
Comment 6 Dmitry Marakasov freebsd_committer 2009-11-28 15:14:54 UTC
State Changed
From-To: open->closed

Committed. Thanks!