Bug 141091 - [nullfs] fix panics with DIAGNOSTIC enabled
Summary: [nullfs] fix panics with DIAGNOSTIC enabled
Status: Closed Unable to Reproduce
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 1.0-CURRENT
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-02 03:00 UTC by Gleb Kurtsou
Modified: 2024-12-24 17:55 UTC (History)
2 users (show)

See Also:

Attachments
file.diff (765 bytes, patch)
2009-12-02 03:00 UTC, Gleb Kurtsou 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gleb Kurtsou freebsd_committer freebsd_triage 2009-12-02 03:00:12 UTC 
null_checkvp function shouldn't be called from null_lock and null_unlock (through NULLVPTOLOWERVP(vp) macro)

null_lock and null_unlock code expects that some of "usual" assumptions on vnodes do not hold, e.g. during node creation and reclaim lower vnode can be null, etc.

example panic backtraces:

http://lists.freebsd.org/pipermail/freebsd-fs/2009-November/007176.html

Fix: disable vnode checks in null_lock and null_unlock

Patch attached with submission follows:
How-To-Repeat: recompile kernel with
options INVARIANT_SUPPORT
options INVARIANTS
options DIAGNOSTIC
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2009-12-02 04:55:31 UTC 
Responsible Changed
From-To: freebsd-bugs->freebsd-fs

Over to maintainer(s).
Comment 2 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 08:00:15 UTC 
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 3 Graham Perrin freebsd_committer freebsd_triage 2022-10-17 12:40:27 UTC 
Keyword: 

    patch
or  patch-ready

– in lieu of summary line prefix: 

    [patch]

* bulk change for the keyword
* summary lines may be edited manually (not in bulk). 

Keyword descriptions and search interface: 

    <https://bugs.freebsd.org/bugzilla/describekeywords.cgi>
Comment 4 Mark Johnston freebsd_committer freebsd_triage 2024-12-24 17:55:07 UTC 
The code in question hasn't changed in the 15 years since this was submitted, so I believe the panic reported on freebsd-fs was due to a real bug.