Bug 141348 - multimedia/vlc: Fix of usage USE_QT= macro.
Summary: multimedia/vlc: Fix of usage USE_QT= macro.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dima Panov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-10 15:50 UTC by Dima Panov
Modified: 2009-12-12 13:11 UTC (History)
0 users

See Also:

Attachments
vlc.diff (1.14 KB, patch)
2009-12-10 15:50 UTC, Dima Panov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dima Panov freebsd_committer freebsd_triage 2009-12-10 15:50:06 UTC 

multimedia/vlc: Fix of usage USE_QT= macro.

Current state of port is incorrect. 
Optional USE_QT should be decrared before including of bsd.port.pre.mk but after bsd.port.options.mk
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-12-10 15:50:27 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->fluffy

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-12-10 15:50:30 UTC 
Maintainer of multimedia/vlc,

Please note that PR ports/141348 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/141348

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2009-12-10 15:50:32 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Joseph S. Atkinson 2009-12-12 03:18:30 UTC 
The problem with this is that it removes one error for USE_QT and triggers two 
more for WITH(OUT)_X11 and WITH(OUT)_SDL.

I have looked at this a bit closer and think I have come up with a fully working 
(deceptively simple) working solution that should go in with vlc 1.0.4, which I 
am working on now.
Comment 5 Dima Panov freebsd_committer freebsd_triage 2009-12-12 13:11:25 UTC 
State Changed
From-To: feedback->closed

Superseded by PR 141393 from maintainer