Bug 141859 - www/webkit-gtk2: ensure dependence on the right "flex" program [PATCH]
Summary: www/webkit-gtk2: ensure dependence on the right "flex" program [PATCH]
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Koop Mast
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-22 02:30 UTC by Carlos Santos
Modified: 2009-12-23 20:20 UTC (History)
0 users

See Also:


Attachments
file.diff (533 bytes, patch)
2009-12-22 02:30 UTC, Carlos Santos
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Santos 2009-12-22 02:30:05 UTC
The BUILD_DEPENDS variable is not set correctly in the webkit-gtk2 port. So if the flex port is not installed previously (possibly to build another port) /usr/bin/flex is used and the build fails. I noticed this because I removed the flex port from my system right before attempting to build webkit-gtk2.

Fix: Apply the patch contained in the attachment.

Patch attached with submission follows:
How-To-Repeat: cd /usr/ports/www/webkit-gtk2
make depends
pkg_delete flex-2.5.35_1
make depends

It will say "webkit-gtk2-1.1.15.4 depends on executable: flex - found"
Comment 1 Edwin Groothuis freebsd_committer 2009-12-22 02:30:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Koop Mast freebsd_committer 2009-12-22 10:56:56 UTC
Responsible Changed
From-To: gnome->kwm

Take this one, I'm working on some webkit patches right now.
Comment 3 dfilter service freebsd_committer 2009-12-23 20:17:40 UTC
kwm         2009-12-23 20:17:31 UTC

  FreeBSD ports repository

  Modified files:
    www/webkit-gtk2      Makefile 
  Added files:
    www/webkit-gtk2/files patch-add-gzip 
                          patch-webkitnetworkresponse 
  Log:
  Look in LOCALBASE for flex, so we don't pick up the version from base. [1]
  
  Add networkreponce support from upstream. [2]
  Add a patch from upstream, to use the gzip encoding support in libsoup 2.28.2.
  However if a website still displays junk. This means that it usesing deflate
  which is not working in libsoup right now (like cvsweb.freebsd.org) [2]
  
  PR:     ports/141859 [1]
  Submitted by:   Carlos A. M. dos Santos <unixmania@gmail.com>
  Obtained from:  Webkit svn trunk.
  
  Revision  Changes    Path
  1.15      +2 -1      ports/www/webkit-gtk2/Makefile
  1.1       +35 -0     ports/www/webkit-gtk2/files/patch-add-gzip (new)
  1.1       +215 -0    ports/www/webkit-gtk2/files/patch-webkitnetworkresponse (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Koop Mast freebsd_committer 2009-12-23 20:19:24 UTC
State Changed
From-To: open->closed

Committed thanks!