This patch fixes a typo in vlc's Makefile (CONFIGURE_ARGS)
Fix: Patch attached with submission follows:
Maintainer of multimedia/vlc,
Please note that PR ports/142160 has just been submitted.
If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.
The full text of the PR can be found at:
Edwin Groothuis via the GNATS Auto Assign Tool
Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
I'd like to commit this along with a change, that removes major numbers
The current situation -- painful everywhere, but especially on ports
with a large number of frequently-changing dependencies -- is that a lot
of things end up rebuilt gratuitously... For example, someone may
install mplayer today, update their ports tree tomorrow, and try to add
vlc on Sunday.
If the major number of any of the shared libraries (libfoo installed by
graphics/foo), that both mplayer and vlc use, changes, addinging vlc
will fail. Instead of simply building vlc, the user will have to:
1. Uninstall mplayer.
2. Uninstall foo.
3. Build a new version of foo.
4. Rebuild mplayer.
5. Rebuild vlc.
Yet in almost all cases vlc does not really care, whether the libfoo is
version 48 or 51... Forcing such a rebuild is completely unnecessary...
Over to maintainer.
Removing shared library tracking from VLC would be a very bad thing.
When shlibs change numbers, so does their functionality. Sometimes they
may be backwards compatible, but not always. Plus, with the way that VLC
uses bleeding edge features willy nilly, and FreeBSDs librabries are
sometimes lagging behind current, keeping these updated sometimes opens
new features or better performance.
I cannot approve this, shlib tracking is implemented in all of the ports
tree for a reason. Port updating utilities generally provide a way to
skip updating of specific ports if you so desire.
Resolve the confusion: I am not the maintainer of this port.
portmgr rejects this patch
kwm 2010-01-07 11:05:18 UTC
FreeBSD ports repository
Fix typo in the --disable-flac case.
Submitted by: Ganael Laplanche <firstname.lastname@example.org>
Approved by: maintainer
Revision Changes Path
1.209 +1 -1 ports/multimedia/vlc/Makefile
email@example.com mailing list
To unsubscribe, send any mail to "firstname.lastname@example.org"