Bug 143572 - [zfs] zpool(1): [patch] The verbose output from iostat does not set the correct column width when multiple pools are displayed.
Summary: [zfs] zpool(1): [patch] The verbose output from iostat does not set the corre...
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 8.0-RELEASE
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-02-05 07:50 UTC by Rui DeSousa
Modified: 2022-10-17 12:40 UTC (History)
0 users

See Also:

Attachments
zpool_main.c.patch (417 bytes, patch)
2010-02-05 07:50 UTC, Rui DeSousa 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rui DeSousa 2010-02-05 07:50:01 UTC 
The verbose output from iostat uses the last pool to set the max column width 
for cb_namewidth thus if prior pools use larger device names then the output 
is not aligned.  The patch passes the cb_namewidth so that max_width returns 
the max name width of all pools.

                    capacity     operations    bandwidth
pool              used  avail   read  write   read  write
---------------  -----  -----  -----  -----  -----  -----
.
.
.
    gpt/hydra6       -      -      0      5  2.88K   329K
    gpt/hydra7       -      -      0      5  2.77K   329K
  mirror          628K  1.98G      0     20      0  2.51M
    gpt/hydra_zil0      -      -      0     20     34  2.51M
    gpt/hydra_zil1      -      -      0     20     34  2.51M
cache                -      -      -      -      -      -
  gpt/hydra_cache0  8.06G  19.8G      0      2  3.37K   259K
  gpt/hydra_cache1  8.12G  19.7G      0      2  6.21K   261K
---------------  -----  -----  -----  -----  -----  -----
system           5.86G  26.1G      1     14  11.0K   208K
  mirror         5.86G  26.1G      1     14  11.0K   208K
    gpt/system0      -      -      0      9  8.26K   208K
    gpt/system1      -      -      0      9  8.02K   208K
---------------  -----  -----  -----  -----  -----  -----

How-To-Repeat: 1. Create two ZFS pools with the first pool having larger device names.
2. zpool iostat -v
Comment 1 Alexander Best freebsd_committer freebsd_triage 2010-10-05 23:21:12 UTC 
Responsible Changed
From-To: freebsd-bugs->freebsd-fs

Over to maintainer(s).
Comment 2 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 08:01:31 UTC 
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 3 Graham Perrin freebsd_committer freebsd_triage 2022-10-17 12:40:29 UTC 
Keyword: 

    patch
or  patch-ready

– in lieu of summary line prefix: 

    [patch]

* bulk change for the keyword
* summary lines may be edited manually (not in bulk). 

Keyword descriptions and search interface: 

    <https://bugs.freebsd.org/bugzilla/describekeywords.cgi>