Bug 144447 - [zfs] sharenfs fsunshare() & fsshare_main() non functional
Summary: [zfs] sharenfs fsunshare() & fsshare_main() non functional
Status: Closed Overcome By Events
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pawel Jakub Dawidek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-03 13:10 UTC by jhell
Modified: 2021-06-30 01:42 UTC (History)
1 user (show)

See Also:
bugmeister: mfc-stable10?
bugmeister: mfc-stable9?
bugmeister: mfc-stable8?

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jhell 2010-03-03 13:10:04 UTC 
After exporting some filesystems from zfs via sharenfs I decided to turn
the shares back off after I was done with them on another machine. To my
surprise the datasets that I had shared previously were still shared.

Process:

# This command adds the share through nfs in /etc/zfs/exports
zfs set sharenfs='-maproot=0 disbatch' exports/svn

bla bla bla after using them for a little while:

# This command should turn off the nfs share and remove the line from
# /etc/zfs/exports and signal mountd or whatever.
zfs set sharenfs=off exports/svn

Lo and behold this line is never removed the share and continues even
through a reboot all while sharenfs=off on the dataset. No no other
datasets are shared at this time.

The line in /etc/zfs/exports changes just fine when changing the options
via "zfs set sharenfs".

I also removed /etc/zfs/exports and repeated the process. It still
continued. Also have destroyed datasets and the nfs share still exists.

Can someone take a look at this ?.

Fix: 

No known fix available at the moment.

It does not look like fsunshare() is being called from the little time
that I actually had to debug this problem before the report.
How-To-Repeat: # This command adds the nfs share in /etc/zfs/exports
zfs set sharenfs='-maproot=0 disbatch' exports/svn

# This command should turn off the nfs share and remove the line from
# /etc/zfs/exports and signal mountd or whatever.
zfs set sharenfs=off exports/svn
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2010-03-03 13:20:45 UTC 
Responsible Changed
From-To: freebsd-bugs->freebsd-fs

Over to maintainer(s).
Comment 2 Pawel Jakub Dawidek freebsd_committer freebsd_triage 2010-03-19 22:48:50 UTC 
State Changed
From-To: open->feedback

I believe this is fixed in FreeBSD 8.x. Could you confirm this?
Comment 3 Pawel Jakub Dawidek freebsd_committer freebsd_triage 2010-03-19 22:48:50 UTC 
Responsible Changed
From-To: freebsd-fs->pjd

I'll take this one.
Comment 4 jhell 2010-03-21 03:37:43 UTC 
I can not confirm this is fixed on 8.X.

Maybe ticso@CC might be able to? or another kind soul running 8.X

Thanks for looking this over.

As I notice 7.3-RELEASE is officially in UPDATING for 20100323 maybe this 
could make it in as a errata?.

-- 

  jhell
Comment 5 jhell 2010-05-10 15:59:15 UTC 
Just a reminder followup to see if anything has changed in the
situation of this PR.

???

-- 

 jhell
Comment 6 Pawel Jakub Dawidek freebsd_committer freebsd_triage 2010-05-10 17:39:48 UTC 
State Changed
From-To: feedback->patched

I believe problem is fixed in HEAD and stable/8, but the submitter is 
looking for someone who can merge it to stable/7.
Comment 7 Pawel Jakub Dawidek freebsd_committer freebsd_triage 2010-05-10 17:39:48 UTC 
Responsible Changed
From-To: pjd->freebsd-fs

I believe problem is fixed in HEAD and stable/8, but the submitter is 
looking for someone who can merge it to stable/7.
Comment 8 Mark Linimon freebsd_committer freebsd_triage 2021-06-30 01:42:01 UTC 
^Triage: overcome by events.