Bug 144514 - [New port] irc/tircd
Summary: [New port] irc/tircd
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-06 22:40 UTC by Gavin Atkinson
Modified: 2010-03-18 01:10 UTC (History)
0 users

See Also:


Attachments
tircd.shar (3.72 KB, text/plain)
2010-03-06 22:40 UTC, Gavin Atkinson
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Atkinson freebsd_committer freebsd_triage 2010-03-06 22:40:00 UTC
tircd presents Twitter as an irc channel. You can connect to tircd
with any IRC client, and tweet as if you were on IRC.  The daemon
supports authentication via OAuth or standard http and https
authentication, and supports direct messages, automatic URL shortening,
and Twitter searching.

Quickstart: in irssi, "/connect localhost 6667 twitpass twituser"
and join #twitter

    - @gavinatkinson
XWWW: http://code.google.com/p/tircd/

Fix: (shar also available at http://people.freebsd.org/~gavin/tircd.shar )
How-To-Repeat: 	N/A
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-03-06 22:40:10 UTC
Class Changed
From-To: maintainer-update->change-request

Fix category (new ports should be change-requests) (via the GNATS Auto 
Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-03-06 22:40:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gavin

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 3 Gavin Atkinson freebsd_committer freebsd_triage 2010-03-06 22:46:03 UTC
Responsible Changed
From-To: gavin->freebsd-ports-bugs

Give this bachk to freebsd-ports-bugs - I don't have a ports commit 
bit.
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2010-03-06 23:22:59 UTC
Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it.
Comment 5 Dmitry Marakasov 2010-03-06 23:36:34 UTC
* Gavin Atkinson (gavin@FreeBSD.org) wrote:

- Why is do-extract magic needed? The ports extracts just fine without it.

- Should use REINPLACE_CMD here:
> Xpost-patch:
> X	${SED}	-e '1s,^#!/usr/bin/perl,#!${PREFIX}/bin/perl,' \
> X		-e 's,/etc/tircd.cfg,${PREFIX}/etc/tircd.cfg,g' \
> X		-i "" ${WRKSRC}/tircd.pl
  may also add ${WRKSRC}/tircd.pod here, to replace /etc/tircd.cfg there
  as well

- This should probably be in either do-build or post-patch
> Xpre-install:
> X	pod2man ${WRKSRC}/tircd.pod > ${WRKSRC}/tircd.1

- The main thing - config file will require special handling to not
  remove/overwrite uses's changes.
> X	${INSTALL_DATA} ${WRKSRC}/tircd.cfg.example ${PREFIX}/etc/tircd.cfg
See http://www.freebsd.org/doc/en/books/porters-handbook/plist-config.html

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru
Comment 6 Gavin Atkinson 2010-03-07 09:07:40 UTC
On Sun, 7 Mar 2010, Dmitry Marakasov wrote:
> * Gavin Atkinson (gavin@FreeBSD.org) wrote:
> 
> - Why is do-extract magic needed? The ports extracts just fine without it.

This is needed because the port extracts to ${WRKDIR}/tircd - which is the 
same place that USE_RC_SUBR would try to write over when it generates the 
rc.d script.  I chatted to wxs on IRC yesterday and this solution whas his 
suggestion.

There seems to be no way to get the generated SUB_FILES files to end up in 
a location other than ${WRKDIR} .  Originally I was using 
"USE_RC_SUBR=yes" and doing the work by hand which worked fine, but 
"portlint -A" classes that construct as a fatal error.

> - Should use REINPLACE_CMD here:
> > Xpost-patch:
> > X	${SED}	-e '1s,^#!/usr/bin/perl,#!${PREFIX}/bin/perl,' \
> > X		-e 's,/etc/tircd.cfg,${PREFIX}/etc/tircd.cfg,g' \
> > X		-i "" ${WRKSRC}/tircd.pl
>   may also add ${WRKSRC}/tircd.pod here, to replace /etc/tircd.cfg there
>   as well

Yes, thanks for catching that.

> - This should probably be in either do-build or post-patch
> > Xpre-install:
> > X	pod2man ${WRKSRC}/tircd.pod > ${WRKSRC}/tircd.1

I'll move it to post-patch then.  Several other ports that use pod2man do 
it in pre-install, so I thought I must be missing some subtle point about 
why it had to be there - I guess not :)

> - The main thing - config file will require special handling to not
>   remove/overwrite uses's changes.
> > X	${INSTALL_DATA} ${WRKSRC}/tircd.cfg.example ${PREFIX}/etc/tircd.cfg
> See http://www.freebsd.org/doc/en/books/porters-handbook/plist-config.html

Ah, I hadn't thought of that, thanks.  Can that be done with the 
PLIST_FILES in the makefile, or do I need to introduce the pkg-plist for 
this?

Many thanks for your review!

Gavin
Comment 7 Dmitry Marakasov 2010-03-07 12:10:08 UTC
* Gavin Atkinson (gavin.atkinson@ury.york.ac.uk) wrote:

> This is needed because the port extracts to ${WRKDIR}/tircd - which is the 
> same place that USE_RC_SUBR would try to write over when it generates the 
> rc.d script.  I chatted to wxs on IRC yesterday and this solution whas his 
> suggestion.

I think you can just rename the script to .sh.in (and use tircd.sh in
USE_RC_SUBR), as USE_RC_SUBR automatically crunches off .sh on installation.

> Ah, I hadn't thought of that, thanks.  Can that be done with the 
> PLIST_FILES in the makefile, or do I need to introduce the pkg-plist for 
> this?

I think adding pkg-plist would be the most clear way, albeit portlint
will complain that it's too small. I guess we should add code to port.mk
that deals with this automatically...

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru
Comment 8 Gavin Atkinson freebsd_committer freebsd_triage 2010-03-07 13:06:11 UTC
On Sun, 7 Mar 2010, Dmitry Marakasov wrote:
> * Gavin Atkinson (gavin.atkinson@ury.york.ac.uk) wrote:
> 
> > This is needed because the port extracts to ${WRKDIR}/tircd - which is the 
> > same place that USE_RC_SUBR would try to write over when it generates the 
> > rc.d script.  I chatted to wxs on IRC yesterday and this solution whas his 
> > suggestion.
> 
> I think you can just rename the script to .sh.in (and use tircd.sh in
> USE_RC_SUBR), as USE_RC_SUBR automatically crunches off .sh on installation.

Thanks for your help with this.  A new copy of the port with all of your 
suggestions is at http://people.freebsd.org/~gavin/tircd.shar

Thanks,

Gavin
Comment 9 Dmitry Marakasov 2010-03-08 23:04:33 UTC
* Gavin Atkinson (gavin@FreeBSD.org) wrote:

> > I think you can just rename the script to .sh.in (and use tircd.sh in
> > USE_RC_SUBR), as USE_RC_SUBR automatically crunches off .sh on installation.
> 
> Thanks for your help with this.  A new copy of the port with all of your 
> suggestions is at http://people.freebsd.org/~gavin/tircd.shar

Here's my variant with additional minor changes. If it's ok I can commit
it right away:

http://people.freebsd.org/~amdmi3/tircd-0.10.shar

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru
Comment 10 Gavin Atkinson freebsd_committer freebsd_triage 2010-03-09 10:15:29 UTC
On Tue, 2010-03-09 at 02:04 +0300, Dmitry Marakasov wrote:
> * Gavin Atkinson (gavin@FreeBSD.org) wrote:
>=20
> > > I think you can just rename the script to .sh.in (and use tircd.sh
> in
> > > USE_RC_SUBR), as USE_RC_SUBR automatically crunches off .sh on
> installation.
> >=20
> > Thanks for your help with this.  A new copy of the port with all of
> your=20
> > suggestions is at http://people.freebsd.org/~gavin/tircd.shar
>=20
> Here's my variant with additional minor changes. If it's ok I can
> commit
> it right away:
>=20
> http://people.freebsd.org/~amdmi3/tircd-0.10.shar

That looks great to me, thanks!

Gavin
Comment 11 Dmitry Marakasov freebsd_committer freebsd_triage 2010-03-18 01:02:47 UTC
State Changed
From-To: open->closed

New port added. Thanks!
Comment 12 dfilter service freebsd_committer freebsd_triage 2010-03-18 01:02:48 UTC
amdmi3      2010-03-18 01:02:40 UTC

  FreeBSD ports repository

  Modified files:
    irc                  Makefile 
  Added files:
    irc/tircd            Makefile distinfo pkg-descr pkg-plist 
    irc/tircd/files      tircd.sh.in 
  Log:
  tircd presents Twitter as an irc channel. You can connect to tircd
  with any IRC client, and tweet as if you were on IRC.  The daemon
  supports authentication via OAuth or standard http and https
  authentication, and supports direct messages, automatic URL shortening,
  and Twitter searching.
  
  Quickstart: in irssi, "/connect localhost 6667 twitpass twituser"
  and join #twitter
  
      - @gavinatkinson
  
  WWW: http://code.google.com/p/tircd/
  
  PR:             144514
  Submitted by:   gavin
  
  Revision  Changes    Path
  1.196     +1 -0      ports/irc/Makefile
  1.1       +49 -0     ports/irc/tircd/Makefile (new)
  1.1       +3 -0      ports/irc/tircd/distinfo (new)
  1.1       +27 -0     ports/irc/tircd/files/tircd.sh.in (new)
  1.1       +12 -0     ports/irc/tircd/pkg-descr (new)
  1.1       +4 -0      ports/irc/tircd/pkg-plist (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"