When use the -v (verbose) option, show progress complete.
hi there, i don't think the original patch you submitted will be accepted by any developer since it breaks the behaviour of `cp -v`. you might want to add a new switch to trigger the extra output from your patch. just be sure you don't use any switch that's already taken by POSIX [1]. however personally i don't think that your patch will be committed even with a new switch. `cp` has been the way it is for a very long time and i don't think people want it to change. you might want to open a new thread on freebsd-hackers@ or freebsd-current@ and ask what the developers think about your patch. this might trigger some interest in this PR. the fact however is that there are a lot of PRs with great and useful additions to FreeBSD. however most people that are using FreeBSD on a daily basis don't want basic applications like `cp` to change. even if a developer would commit your patch it is most likely that he'll be forced to revert the changes due to the fact that other developers don't see the need for such a change. i would expect the argument to be something like this: "the behavior of cp hasn't change since 1977. cp didn't need this feature back then and it doesn't need it now." personally i don't agree with this point of view. good luck and i hope your patch will somehow make it into the tree. i've applied your patch to my local src tree and try to use the -v when copying large files. i really like it. :) cheers. alex [1] http://www.opengroup.org/onlinepubs/9699919799/ -- a13x
State Changed From-To: open->suspended no src committer has taken any interest in this patch. there are probably a number of reasons for that: - your patch adds new functionality to a very basic UNIX application. in general those patches will almost never make it into the src tree, because people tend to consider those applications to be "perfectly designed without any need for additions" - the funcionality of your patch can be reproduced by hitting ^T during copying - alternatives to the base cp with the same or more advanced features than your patch exist in the ports collection for those reasons i'm suspending this PR. thanks a lot for your work and sorry for not attracting any committer. i highly recommend you get a few opinions from committers on freebsd-hackers@ or freebsd-current@ next time before implementing new features into long existing applications. cheers. alex
Just for the record, I had adjusted this for local use. And while being a useful feature especially when it comes to doing simple operations such as cp(1), I also find this to be very handy as standard cp(1) does not let you see what it is actually copying until after the copy has completed. Also for the record "The -v and -n options are non-standard and their use in scripts is not recommended." I don't see a reason why there should/could not be another non-standard feature added as -v as I stated is not really useful until the actual copy of the file has completed. The local mods that I made for this patch was to make it take '-V' as a argument instead of defaulting to '-v' and adjusting the manual page to properly document it. Patch is attached for archive sake. It is a shame it couldn't be incorporated. -- jhell,v
State Changed From-To: suspended->open open PR until someone definitively says "no - this will never make it in" or "yes - we want this. Unlike most other RFEs this one includes a patch.
For bugs matching the following criteria: Status: In Progress Changed: (is less than) 2014-06-01 Reset to default assignee and clear in-progress tags. Mail being skipped
As Alexander mentioned - this feature is unlikely to be added to cp(1) unless someone with commit bit would push it through review. Considering this I'm closing it as "Rejected". If somebody wants to pick this PR up and work on it - please feel free to reopen.