Bug 144794 - multimedia/aegisub: fails to build with multiple option combinations
Summary: multimedia/aegisub: fails to build with multiple option combinations
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-16 15:30 UTC by Dmitry Marakasov
Modified: 2012-04-23 14:26 UTC (History)
1 user (show)

See Also:


Attachments
aegisub.shar.txt (8.39 KB, text/plain)
2010-03-17 17:08 UTC, Leinier Cruz Salfran
no flags Details
aegisub.shar.txt (8.34 KB, text/plain)
2010-03-17 21:18 UTC, Leinier Cruz Salfran
no flags Details
aegisub.shar.txt (8.34 KB, text/plain)
2010-03-17 21:18 UTC, Leinier Cruz Salfran
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov 2010-03-16 15:30:01 UTC
Fails to build, likely due to the fact that both portaudio-18.1_2 and portaudio-19.20071207 are installed:

http://people.freebsd.org/~amdmi3/aegisub-local.log

note that disabling portaudio option doesn't help, as the port lack corresponding CONFIGURE_ARGS+=--without-...

Also, fails in tinderbox:

WITH_EFENCE:
http://people.freebsd.org/~amdmi3/aegisub-efence-2.1.8.log
WITH_GCOV:
http://people.freebsd.org/~amdmi3/aegisub-efence-2.1.8.log

(why do you need debug and profile options in the port at all?)

WITHOUT_LUA:
http://people.freebsd.org/~amdmi3/aegisub-nolua-2.1.8.log
WITHOUT_PERL:
http://people.freebsd.org/~amdmi3/aegisub-noperl-2.1.8.log

Has other problems: no such thing as USE_FREETYPE2, typo in uSE_PERL5, CFLAGS in CONFIGURE_ENV (see portlint, should likely use CPPFLAGS instead), depend on pkgconfig not via USE_GNOME=pkgconfig, hardcoded WX version in include dirs.

Likely BUILD/RUN/LIB dependencies problems and more hidden depends (due to lack of --without-...)

Also, the port would be much more readable with line spacings between conditional statements.

Port maintainer (salfrancl@yahoo.es) is cc'd.

Generated with FreeBSD Port Tools 0.99
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-03-16 15:30:08 UTC
Maintainer of multimedia/aegisub,

Please note that PR ports/144794 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/144794

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-03-16 15:30:11 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2010-03-16 17:47:26 UTC
Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it.
Comment 4 Leinier Cruz Salfran 2010-03-17 17:08:07 UTC
Hello Dmitri and others.

I made some modifications in order to fix errors you mentioned in the last mail .. I wonder if you test this new changes in which i handle '--disable-*' and '--without-*' parameters in order to get a complete compilation of the port .. Notify if there is any errors, please.


      
Comment 5 Leinier Cruz Salfran 2010-03-17 21:18:20 UTC
Hello once again. I made a modification to 'Makefile': 'USE_GNOME= pkgconfig intlhack'. I think the port is better now. When I install 'tinderbox' again I'll begin to send the 'tinderbox' compilation logs too.


      
Comment 6 Leinier Cruz Salfran 2010-03-17 21:18:20 UTC
Hello once again. I made a modification to 'Makefile': 'USE_GNOME= pkgconfig intlhack'. I think the port is better now. When I install 'tinderbox' again I'll begin to send the 'tinderbox' compilation logs too.


      
Comment 7 Eitan Adler freebsd_committer freebsd_triage 2011-09-24 19:11:02 UTC
State Changed
From-To: feedback->suspended

please use a diff instead of a shar
Comment 8 Dmitry Marakasov 2011-09-24 22:19:00 UTC
This was sent some time ago. Sorry, forgot to cc bug-followup.

Since there was no feedback, I'm gonna commit this quite soon.

----- Forwarded message from Dmitry Marakasov <amdmi3@hades.panopticon> -----

Date: Thu, 8 Sep 2011 08:30:45 +0400
From: Dmitry Marakasov <amdmi3@hades.panopticon>
To: "Leinier C. Salfran" <salfrancl@yahoo.es>
Subject: Re: ports/144794: multimedia/aegisub: fails to build with multiple option combinations

* Leinier C. Salfran (salfrancl@yahoo.es) wrote:

>  Hello once again. I made a modification to 'Makefile': 'USE_GNOME=3D pkgcon=
>  fig intlhack'. I think the port is better now. When I install 'tinderbox' a=
>  gain I'll begin to send the 'tinderbox' compilation logs too.

Sorry for delay, I've completely forgot about this PR.

I've modified the patch a bit, diff agaist current version of a
port is [1], diff against your update is [2]. Plist is now clean,
the only problem is that efence, gcov and ffmpeg options still do
not build, so I've commented them out for now.

Changes include:
- properly depend on freetype and fontconfig (these are libs and
  there's no such thing as USE_FREETYPE2)
- don't use x11 category (especially as primary), the port doesn't
  really belong there
- depend on OpenGL since it's required
- append (not set) CFLAGS/LDFLAGS to not clobber user-set values
- comment out broken options
- minor whitespace cleanup to make a port more readable
- fix depend on hunspell - it should be textproc/hunspell as
  hungarian/ port is just a dictionary. Also improve option description
  as hunspell supports other languages besides hungarian
- correctly handle files that may or may not be installed depending on
  options (PERL and LUA)
- cleanup plist to use %%DATADIR%%/%%DOCSDIR%% macros and some
  more required @dirrmtry's

[1] http://people.freebsd.org/~amdmi3/aegisub-vs-oldport.diff
[2] http://people.freebsd.org/~amdmi3/aegisub-vs-update.diff

Failure logs:

http://people.freebsd.org/~amdmi3/aegisub-efence-2.1.8_4.log
http://people.freebsd.org/~amdmi3/aegisub-ffmpeg-2.1.8_4.log
http://people.freebsd.org/~amdmi3/aegisub-gcov-2.1.8_4.log

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru

----- End forwarded message -----

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru
Comment 9 Dmitry Marakasov freebsd_committer freebsd_triage 2011-09-24 22:20:18 UTC
State Changed
From-To: suspended->feedback

That was wrong state
Comment 10 Philip M. Gollucci freebsd_committer freebsd_triage 2012-02-09 02:35:16 UTC
State Changed
From-To: feedback->open

maintainer timeout (salfrancl@yahoo.es ; 138 days)
Comment 11 Dmitry Marakasov freebsd_committer freebsd_triage 2012-04-23 14:26:43 UTC
State Changed
From-To: open->closed

No longer needed after lastest aegisub update