Bug 144929 - [ufs] [lor] vfs_bio.c + ufs_dirhash.c
Summary: [ufs] [lor] vfs_bio.c + ufs_dirhash.c
Status: Closed Not A Bug
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 9.0-CURRENT
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-21 17:20 UTC by Ryan Steinmetz
Modified: 2020-04-03 16:48 UTC (History)
1 user (show)

See Also:

Attachments
file.txt (8.50 KB, text/plain)
2010-03-21 17:20 UTC, Ryan Steinmetz 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Steinmetz 2010-03-21 17:20:03 UTC 
lock order reversal:
 1st 0xcd2e2b88 bufwait (bufwait) @ /usr/src/sys/kern/vfs_bio.c:2559
 2nd 0xc3554400 dirhash (dirhash) @ /usr/src/sys/ufs/ufs/ufs_dirhash.c:285
KDB: stack backtrace:
db_trace_self_wrapper(c0ca3e8b,d616074c,c08d7395,c08c7fab,c0ca6d96,...) at db_trace_self_wrapper+0x26
kdb_backtrace(c08c7fab,c0ca6d96,c312efc8,c3132228,d61607a8,...) at kdb_backtrace+0x29
_witness_debugger(c0ca6d96,c3554400,c0cc88f8,c3132228,c0cc857d,...) at _witness_debugger+0x25
witness_checkorder(c3554400,9,c0cc857d,11d,0,...) at witness_checkorder+0x839
_sx_xlock(c3554400,0,c0cc857d,11d,c399cb54,...) at _sx_xlock+0x85
ufsdirhash_acquire(cd2e2b28,ce0e4800,200,ce0e484c,d6160878,...) at ufsdirhash_acquire+0x35
ufsdirhash_add(c399cb54,d61608d0,84c,d6160864,d6160868,...) at ufsdirhash_add+0x13
ufs_direnter(c398a330,c3a23cc0,d61608d0,d6160bd0,0,...) at ufs_direnter+0x729
ufs_makeinode(d6160bd0,0,d6160abc,d6160a18,c0be1d15,...) at ufs_makeinode+0x50d
ufs_create(d6160abc,d6160ad4,0,0,d6160ba4,...) at ufs_create+0x30
VOP_CREATE_APV(c0dad960,d6160abc,d6160bd0,d6160a54,0,...) at VOP_CREATE_APV+0xa5
vn_open_cred(d6160ba4,d6160c5c,1a4,0,c3575a00,...) at vn_open_cred+0x215
vn_open(d6160ba4,d6160c5c,1a4,c34e61f8,c0cc99d2,...) at vn_open+0x3b
kern_openat(c398db40,ffffff9c,284661f0,0,a02,...) at kern_openat+0x11f
kern_open(c398db40,284661f0,0,a01,1a4,...) at kern_open+0x35
open(c398db40,d6160cf8,c0cdac1c,c0ca75e6,c394c000,...) at open+0x30
syscall(d6160d38) at syscall+0x220
Xint0x80_syscall() at Xint0x80_syscall+0x20
--- syscall (5, FreeBSD ELF32, open), eip = 0x28342a93, esp = 0xbfbfe89c, ebp = 0xbfbfe8c8 ---

Fix: Patch attached with submission follows:
How-To-Repeat: Freshly installed the 9.0-CURRENT snapshot 201002 (under ESXi) and ran 'portsnap fetch extract' and received the LOR message.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2010-03-21 20:08:19 UTC 
Responsible Changed
From-To: freebsd-bugs->freebsd-fs

Take a guess and turn this over to freebsd-fs@.
Comment 2 Ryan Steinmetz 2011-06-02 02:02:26 UTC 
This is from FreeBSD-9.0-CURRENT-201105, under ESX4i:

freebsd9# uname -a
FreeBSD freebsd9 9.0-CURRENT FreeBSD 9.0-CURRENT #0: Thu May 12 11:28:09 UTC 2011     root@obrian.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386

Jun  2 00:52:39 freebsd9 kernel: lock order reversal:
Jun  2 00:52:39 freebsd9 kernel: 1st 0xc2a3aaf8 isofs (isofs) @ /usr/src/sys/kern/vfs_mount.c:1193
Jun  2 00:52:39 freebsd9 kernel: 2nd 0xc2a3c168 devfs (devfs) @ /usr/src/sys/ufs/ffs/ffs_vfsops.c:1267
Jun  2 00:52:39 freebsd9 kernel: KDB: stack backtrace:
Jun  2 00:52:39 freebsd9 kernel: db_trace_self_wrapper(c0e8047a,7366662f,7366765f,2e73706f,32313a63,...) at db_trace_self_wrapper+0x26
Jun  2 00:52:39 freebsd9 kernel: kdb_backtrace(c09ddcdb,c0e83cff,c2568a48,c25689e0,c739e9ac,...) at kdb_backtrace+0x2a
Jun  2 00:52:39 freebsd9 kernel: _witness_debugger(c0e83cff,c2a3c168,c0e6b68b,c25689e0,c0eb124c,...) at _witness_debugger+0x25
Jun  2 00:52:39 freebsd9 kernel: witness_checkorder(c2a3c168,9,c0eb124c,4f3,c2a3c188,...) at witness_checkorder+0x839
Jun  2 00:52:39 freebsd9 kernel: __lockmgr_args(c2a3c168,80400,c2a3c188,0,0,...) at __lockmgr_args+0x804
Jun  2 00:52:39 freebsd9 kernel: vop_stdlock(c739eacc,c2a3c1bc,c739eac4,80400,c2a3c110,...) at vop_stdlock+0x62
Jun  2 00:52:39 freebsd9 kernel: VOP_LOCK1_APV(c0f85ec0,c739eacc,c299f000,c0fca6a0,c2a3c110,...) at VOP_LOCK1_APV+0xb5
Jun  2 00:52:39 freebsd9 kernel: _vn_lock(c2a3c110,80400,c0eb124c,4f3,c27c5400,...) at _vn_lock+0x5e
Jun  2 00:52:39 freebsd9 kernel: ffs_flushfiles(c28e5510,2,c28ce5c0,59f,3,...) at ffs_flushfiles+0xa7
Jun  2 00:52:39 freebsd9 kernel: softdep_flushfiles(c28e5510,2,c28ce5c0,0,c0fca6c0,...) at softdep_flushfiles+0x2e
Jun  2 00:52:39 freebsd9 kernel: ffs_unmount(c28e5510,80000,c739ebc0,4ee,c739ebcc,...) at ffs_unmount+0x149
Jun  2 00:52:39 freebsd9 kernel: dounmount(c28e5510,80000,c28ce5c0,c221762c,0,...) at dounmount+0x466
Jun  2 00:52:39 freebsd9 kernel: vfs_unmountall(c0e7c3b9,0,c0e7c307,12f,c28ce5c0,...) at vfs_unmountall+0x4e
Jun  2 00:52:39 freebsd9 kernel: kern_reboot(0,0,c0e7c307,b2,c28c8000,...) at kern_reboot+0x450
Jun  2 00:52:39 freebsd9 kernel: reboot(c28ce5c0,c739ecec,c739ed80,c739ec88,0,...) at reboot+0x6c
Jun  2 00:52:39 freebsd9 kernel: syscallenter(c28ce5c0,c739ece4,c0ccb2f6,3,c10148c0,...) at syscallenter+0x263
Jun  2 00:52:39 freebsd9 kernel: syscall(c739ed28) at syscall+0x34
Jun  2 00:52:39 freebsd9 kernel: Xint0x80_syscall() at Xint0x80_syscall+0x21
Jun  2 00:52:39 freebsd9 kernel: --- syscall (55, FreeBSD ELF32, reboot), eip = 0x280b8ccb, esp = 0xbfbfec8c, ebp = 0xbfbfedd8 ---

Jun  2 00:58:38 freebsd9 kernel: lock order reversal:
Jun  2 00:58:38 freebsd9 kernel: 1st 0xc225db78 bufwait (bufwait) @ /usr/src/sys/kern/vfs_bio.c:2658
Jun  2 00:58:38 freebsd9 kernel: 2nd 0xc2721800 dirhash (dirhash) @ /usr/src/sys/ufs/ufs/ufs_dirhash.c:284
Jun  2 00:58:38 freebsd9 kernel: KDB: stack backtrace:
Jun  2 00:58:38 freebsd9 kernel: db_trace_self_wrapper(c0e8047a,7366752f,7366752f,7269645f,68736168,...) at db_tra
Jun  2 00:58:38 freebsd9 kernel: ce_self_wrapper+0x26
Jun  2 00:58:38 freebsd9 kernel: kdb_backtrace(c09ddcdb,c0e83cff,c25652a0,c2568b18,ccffd7e8,...) at 
Jun  2 00:58:38 freebsd9 kernel: kdb_backtrace+0x2a
Jun  2 00:58:38 freebsd9 kernel: _witness_debugger(c0e83cff,c2721800,c0eb20ae,c2568b18,c0eb1d33,...) at 
Jun  2 00:58:38 freebsd9 kernel: _witness_debugger+0x25
Jun  2 00:58:38 freebsd9 kernel: witness_checkorder(c2721800,9,c0eb1d33,11c,0,...) at witness_checkorder+0x839
Jun  2 00:58:38 freebsd9 kernel: _
Jun  2 00:58:38 freebsd9 kernel: sx_xlock(c2721800,0,c0eb1d33,11c,c2bf015c,...) at _s
Jun  2 00:58:38 freebsd9 kernel: x_xlock+0x85
Jun  2 00:58:38 freebsd9 kernel: ufsdirhash_acquire(c225db18,c8138800,200,c8138814,ccffd8b8,...) at ufsdirhash_acq
Jun  2 00:58:38 freebsd9 kernel: uire+0x35
Jun  2 00:58:38 freebsd9 kernel: ufsdirhash_add(c2bf015c,ccffd914,814,ccffd8a4,ccffd8a8,...) at ufsdirhash_add+0x13
Jun  2 00:58:38 freebsd9 kernel: ufs_direnter(c2bf9990,c2c27440,ccffd914,ccffdba4,0,...) at ufs_direnter+0x6f9
Jun  2 00:58:38 freebsd9 kernel: ufs_makeinode(ccffdba4,0,ccffdb00,ccffda5c,c0cecb55,...) at ufs_makeinode+0x557
Jun  2 00:58:38 freebsd9 kernel: ufs_create(ccffdb00,ccffdb18,0,0,ccffdb78,...) at ufs_create+0x30
Jun  2 00:58:38 freebsd9 kernel: VOP_CREATE_APV(c0faf7c0,ccffdb00,ccffdba4,ccffda98,0,...) at VOP_CREATE_APV+0xa5
Jun  2 00:58:38 freebsd9 kernel: vn_open_cred(ccffdb78,ccffdc2c,1a4,0,c2bcd500,...) at vn_open_cred+0x215
Jun  2 00:58:38 freebsd9 kernel: vn_open(ccffdb78,ccffdc2c,1a4,c2909070,0,...) at vn_open+0x3b
Jun  2 00:58:38 freebsd9 kernel: kern_openat(c2a9ab80,ffffff9c,28414180,0,a02,...) at kern_openat+0x12f
Jun  2 00:58:38 freebsd9 kernel: kern_open(c2a9ab80,28414180,0,a01,1a4,...) at kern_open+0x35
Jun  2 00:58:38 freebsd9 kernel: open(c2a9ab80,ccffdcec,ccffdd28,c0e825f6,0,...) at open+0x30
Jun  2 00:58:38 freebsd9 kernel: syscallenter(c2a9ab80,ccffdce4,ccffdce4,2,c10148c0,...) at syscallenter+0x263
Jun  2 00:58:38 freebsd9 kernel: syscall(ccffdd28) at syscall+0x34
Jun  2 00:58:38 freebsd9 kernel: Xint0x80_syscall() at Xint0x80_syscall+0x21
Jun  2 00:58:38 freebsd9 kernel: --- syscall (5, FreeBSD ELF32, open), eip = 0x283706a3, esp = 0xbfbfe6dc, ebp = 0xbfbfe708 ---
Comment 3 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 07:58:37 UTC 
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 4 Mark Johnston freebsd_committer freebsd_triage 2020-04-03 16:48:47 UTC 
This report is a false positive.  We now suppress it.