Update to 1.1.3 This is a bug-fix release addressing the following issues: * rdup: fix reset atime (-a) * rdup-simple: add -a (reset atime flag) * documentation bugfixes Fix: Portfiles modified (minor changes only): - Makefile - distinfo - files/patch-GNUmakefile.in - files/patch-rdup-simple.in Portfiles added/removed: - None
Responsible Changed From-To: freebsd-ports-bugs->amdmi3 I'll take it.
State Changed From-To: open->feedback If you use bash and gdate/gcp, you should depend on shells/bash & sysutils/coreutils; much better would be to patch it to work with standard bsd utils
On Mon 29 Mar 2010 at 07:36:04 PDT amdmi3@FreeBSD.org wrote: >Synopsis: [MAINTAINER] sysutils/rdup: update to 1.1.3 > >State-Changed-From-To: open->feedback >State-Changed-By: amdmi3 >State-Changed-When: Mon Mar 29 14:36:03 UTC 2010 >State-Changed-Why: >If you use bash and gdate/gcp, you should depend on shells/bash & >sysutils/coreutils; much better would be to patch it to work with >standard bsd utils > >http://www.freebsd.org/cgi/query-pr.cgi?pr=144998 The main part of rdup does not depend on bash or coreutils, and is usable without them. rdup-simple provides an example of how to use rdup, but is not an essential component. It uses features of gdate and gcp which would be difficult to replicate using the BSD utilities. It's probably not worth the time to try. Rather than force all rdup users to install bash and coreutils, I'd rather add an OPTION to install rdup-simple, and only trigger the bash and coreutils dependencies when it is selected. If you agree that this makes more sense, I'll get to work on revising the port.
* Charlie Kester (corky1951@comcast.net) wrote: > >Synopsis: [MAINTAINER] sysutils/rdup: update to 1.1.3 > > > >State-Changed-From-To: open->feedback > >State-Changed-By: amdmi3 > >State-Changed-When: Mon Mar 29 14:36:03 UTC 2010 > >State-Changed-Why: > >If you use bash and gdate/gcp, you should depend on shells/bash & > >sysutils/coreutils; much better would be to patch it to work with > >standard bsd utils > > > >http://www.freebsd.org/cgi/query-pr.cgi?pr=144998 > > The main part of rdup does not depend on bash or coreutils, and is > usable without them. > > rdup-simple provides an example of how to use rdup, but is not an > essential component. It uses features of gdate and gcp which would be > difficult to replicate using the BSD utilities. It's probably not worth > the time to try. > > Rather than force all rdup users to install bash and coreutils, I'd > rather add an OPTION to install rdup-simple, and only trigger the bash > and coreutils dependencies when it is selected. That is acceptable. However, please converting the script to use system tools - I don't think it would be hard. For example, the first and the last change from the patch work fine with system date; cp should work as well after changing -r to -R. Remaining date invocation looks like it can be reworked using -v option of our system date. Also looks that the script can be pretty easily converted to plain sh, by replacing [[...]] with [...]. If these changes are possible, it'll solve the problem in a clearer way not requiring any extra options and/or depends. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
On Mon 29 Mar 2010 at 09:40:07 PDT Dmitry Marakasov wrote: >However, please converting the script to use system tools - I don't >think it would be hard. > >For example, the first and the last change from the patch work fine >with system date; cp should work as well after changing -r to -R. >Remaining date invocation looks like it can be reworked using -v option >of our system date. > >Also looks that the script can be pretty easily converted to plain sh, >by replacing [[...]] with [...]. > >If these changes are possible, it'll solve the problem in a clearer way >not requiring any extra options and/or depends. OK, I'll take another look at the rdup-simple script. When I prepared the patch for this PR, I did a global search and replace to change date to gdate. I agree, that picked up some instances where gdate is not really needed. -- Charlie
Attached is a revised diff to upgrade this port to vesion 1.1.3 Per your suggestion, I have converted the rdup-simple script to use /bin/sh rather than bash, and have also removed the dependencies on coreutils. While testing the revised script, I discovered a nasty crashing bug in rdup-up. Fixing this requires reverting to mkpath.c from rdup-1.1.1, and this is what the new files/patch-mkpath.c does. (I have reported this bug to the upstream author.) -- Charlie
Unless you're ready to commit it, you might as well stop work on this PR. The upstream author has just released version 1.1.4, incorporating my reversion of mkpath.c and some other bugfixes. (He also promises less frequent updates in the foreseeable future.) -- Charlie
Please close this PR. I've submitted another one, 145588, to update rdup from version 1.1.2 to 1.1.4. (It incorporates the changes you suggested while working on this one.)
State Changed From-To: feedback->closed Superceded by ports/145588