Bug 145254 - [PATCH] audio/csound fltk fixes
Summary: [PATCH] audio/csound fltk fixes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pietro Cerutti
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-01 06:50 UTC by Chris Petrik
Modified: 2010-04-07 07:50 UTC (History)
0 users

See Also:


Attachments
file.diff (3.39 KB, patch)
2010-04-01 06:50 UTC, Chris Petrik
no flags Details | Diff
patch-csound-new.txt (3.40 KB, patch)
2010-04-01 07:50 UTC, Chris Petrik
no flags Details | Diff
patch-csound-new.txt (3.29 KB, patch)
2010-04-01 08:40 UTC, Chris Petrik
no flags Details | Diff
patch-csound-new.txt (3.34 KB, patch)
2010-04-01 09:04 UTC, Chris Petrik
no flags Details | Diff
patch-csound-plist.txt (844 bytes, patch)
2010-04-01 11:12 UTC, Chris Petrik
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Petrik 2010-04-01 06:50:03 UTC
1. Add some detection for FLTK if it already installed dont install, if the user doesn't want GUI add and option to disable it
2. add pkg-plist hack to lease above
3. remove fltk script as fltk now defaults with threads.

Fix: Patch attached with submission follows:
Comment 1 Chris Petrik 2010-04-01 07:50:13 UTC
Use this patch as the other was a test.

Chris
Comment 2 Pietro Cerutti freebsd_committer 2010-04-01 08:34:46 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gahr

I'll take it.
Comment 3 Pietro Cerutti freebsd_committer 2010-04-01 08:35:16 UTC
State Changed
From-To: open->feedback

Waiting for a revised patch, as discussed with submitter on IRC.
Comment 4 Chris Petrik 2010-04-01 08:40:15 UTC
<html><body><span style="font-family:Verdana; color:#000000; font-size:10pt;"><div>New patch removing the .if exists()</div><div><br></div><div>I will leave the port as is, fix the other ports I need to fix then go back to this port and add proper OPTIONS to all aspects of csound which should take a while.</div><div><br></div><div>Chris<br></div></span></body></html>
Comment 5 Chris Petrik 2010-04-01 09:04:51 UTC
<html><body><span style="font-family:Verdana; color:#000000; font-size:10pt;"><div>Hopefully the last patch sorry :)</div><div><br></div><div>Doing too many things at once getting all mixed up.<br></div></span></body></html>
Comment 6 Chris Petrik 2010-04-01 11:12:18 UTC
Should fix the issues regarding without fltk.

Comment 7 dfilter service freebsd_committer 2010-04-01 16:24:34 UTC
gahr        2010-04-01 15:24:25 UTC

  FreeBSD ports repository

  Modified files:
    audio/csound         Makefile pkg-plist 
  Log:
  - Make fltk optional
  
  PR:             145254
  Submitted by:   Chris Petrik <chris@officialunix.com> (maintainer)
  
  Revision  Changes    Path
  1.51      +18 -8     ports/audio/csound/Makefile
  1.6       +3 -3      ports/audio/csound/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Pietro Cerutti freebsd_committer 2010-04-01 16:24:53 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 9 dfilter service freebsd_committer 2010-04-07 07:40:37 UTC
gahr        2010-04-07 06:40:28 UTC

  FreeBSD ports repository

  Removed files:
    audio/csound/scripts check-fltk-threads.sh 
  Log:
  - Remove file supposed to be deleted by previous commit [1]
  
  PR:             145254 [1]
  Submitted by:   Chris Petrik <chris@officialunix.com> (maintainer)
  
  Revision  Changes    Path
  1.4       +0 -10     ports/audio/csound/scripts/check-fltk-threads.sh (dead)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"