Bug 146125 - [maintainer] archivers/libpar2 segfault fix and cancellation enhancement.
Summary: [maintainer] archivers/libpar2 segfault fix and cancellation enhancement.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-28 22:10 UTC by Toxic
Modified: 2010-05-10 07:10 UTC (History)
0 users

See Also:


Attachments
file.diff (7.39 KB, patch)
2010-04-28 22:10 UTC, Toxic
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toxic 2010-04-28 22:10:01 UTC
This update includes two patches submitted against libpar2 by Andrei Prygounkov, author of nzbget.

One of them is a bugfix that closes a memory leak triggered by corrupted PAR2 files. That fix is included in some linux vendors' libpar2 packages, and is well-tested.

The other adds additional functionality: a method to cancel a file repair in progress.  This patch can be disabled through a config option.  It is enabled by default because the only application in the ports tree that links against libpar2 is news/nzbget.  Nzbget makes use of this functionality if it is available.

It appears that libpar2 has been abandoned upstream (there's been no activity in the CVS tree since 2006).  If it were being maintained, both of these patches would likely be included.

Fix: Patch attached with submission follows:
Comment 1 Martin Wilke freebsd_committer 2010-05-10 07:04:43 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 2 dfilter service freebsd_committer 2010-05-10 07:04:44 UTC
miwi        2010-05-10 06:04:30 UTC

  FreeBSD ports repository

  Modified files:
    archivers/libpar2    Makefile 
    archivers/libpar2/files patch-ChangeLog 
  Added files:
    archivers/libpar2/files patch-par2repairer.cpp 
                            xpatch-addcancel-par2repairer.cpp 
  Log:
  - Includes two patches
  
          * a bugfix that closes a memory leak triggered by corrupted PAR2 files.
            That fix is included in some linux vendors' libpar2 packages, and is
            well-tested.
          * The other adds additional functionality: a method to cancel a file
            repair in progress. This patch can be disabled through a config option.
            It is enabled by default because the only application in the ports tree
            that links against libpar2 is news/nzbget. Nzbget makes use of this
            functionality if it is available.
  
  PR:             146125
  Submitted by:   Jeff Burchell <toxic@doobie.com> (maintainer)
  
  Revision  Changes    Path
  1.5       +10 -2     ports/archivers/libpar2/Makefile
  1.2       +7 -3      ports/archivers/libpar2/files/patch-ChangeLog
  1.1       +36 -0     ports/archivers/libpar2/files/patch-par2repairer.cpp (new)
  1.1       +194 -0    ports/archivers/libpar2/files/xpatch-addcancel-par2repairer.cpp (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"