Bug 146533 - [patch] convert unzip -a to USE_DOS2UNIX
[patch] convert unzip -a to USE_DOS2UNIX
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: FreeBSD ports mailing list
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-13 03:00 UTC by spam
Modified: 2010-06-03 17:00 UTC (History)
0 users

See Also:


Attachments
file.diff (9.05 KB, patch)
2010-05-13 03:00 UTC, spam
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description spam 2010-05-13 03:00:16 UTC
Native unzip can't reliably detect text files(limitation of libarchive),
because of that dos2unix line conversion is dangerous. Convert all uses of
unzip -a to USE_DOS2UNIX in preparation of use native unzip in ports. Also take
maintainership of graphics/fli2gif.

List of ports:
games/darkplaces
games/quake2-ctf
games/quake2-data
games/xevil
graphics/fli2gif
misc/astrolog
misc/projectionlib
print/acrobatviewer
sysutils/megarc
textproc/docbook-420
textproc/iso8879

Fix: Patch attached with submission follows:
Comment 1 pav freebsd_committer 2010-06-03 16:01:13 UTC
State Changed
From-To: open->feedback

iso8879 patch does not look correct to me - it's using unzip in install phase, 
and that's not covered by EXTRACT_DEPENDS implied by USE_ZIP
Comment 2 pav freebsd_committer 2010-06-03 16:54:06 UTC
State Changed
From-To: feedback->closed

Committed, thanks!
Comment 3 dfilter freebsd_committer 2010-06-03 16:54:38 UTC
pav         2010-06-03 15:54:29 UTC

  FreeBSD ports repository

  Modified files:
    games/darkplaces     Makefile 
    games/quake2-ctf     Makefile 
    games/quake2-data    Makefile 
    games/xevil          Makefile 
    graphics/fli2gif     Makefile 
    misc/astrolog        Makefile 
    misc/projectionlib   Makefile 
    print/acrobatviewer  Makefile 
    sysutils/megarc      Makefile 
    textproc/docbook-420 Makefile 
    textproc/iso8879     Makefile 
  Added files:
    graphics/fli2gif/files patch-fli2gif.c 
  Removed files:
    graphics/fli2gif/files patch-ab 
  Log:
  - Convert unzip -a to USE_DOS2UNIX
  
  PR:             ports/146533
  Submitted by:   Alex Kozlov <spam@rm-rf.kiev.ua>
  
  Revision  Changes    Path
  1.19      +4 -3      ports/games/darkplaces/Makefile
  1.3       +2 -1      ports/games/quake2-ctf/Makefile
  1.13      +1 -0      ports/games/quake2-data/Makefile
  1.24      +2 -1      ports/games/xevil/Makefile
  1.15      +4 -3      ports/graphics/fli2gif/Makefile
  1.4       +0 -40     ports/graphics/fli2gif/files/patch-ab (dead)
  1.1       +57 -0     ports/graphics/fli2gif/files/patch-fli2gif.c (new)
  1.44      +2 -1      ports/misc/astrolog/Makefile
  1.10      +1 -2      ports/misc/projectionlib/Makefile
  1.12      +1 -0      ports/print/acrobatviewer/Makefile
  1.9       +2 -1      ports/sysutils/megarc/Makefile
  1.5       +1 -1      ports/textproc/docbook-420/Makefile
  1.23      +1 -0      ports/textproc/iso8879/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"