Bug 146555 - [patch] port graphics/pear-Image_Graph fix php53 issues
Summary: [patch] port graphics/pear-Image_Graph fix php53 issues
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-13 23:10 UTC by Olli Hauer
Modified: 2010-05-15 06:20 UTC (History)
1 user (show)

See Also:


Attachments
patch_pear-Image_Graph.txt (1.12 KB, text/plain)
2010-05-13 23:10 UTC, Olli Hauer
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olli Hauer 2010-05-13 23:10:08 UTC
pear-Image_Graph is broken with php 5.3 see http://pear.php.net/bugs/bug.php?id=16529

Fix: The following patch makes pear-Image_Graph working again with php 5.3.

Additional only *.php files are processed by REINPLACE_CMD, no longer
all files (even graphics where changed with an additional newline)

I tested the patch with php 5.3 and 5.2 so I think it is save to
use '.if ${PHP_VER} != 4' as condition, but I suggest a further test.

How-To-Repeat: Install php 5.3.x and pear-Image_Graph and apache

Enable web access to the following folder
 ${PREFIX}/share/doc/pear/Image_Graph/examples/

now open the index.html inside ${PREFIX}/share/doc/pear/Image_Graph/examples/
and watch the browser output and the httpd logs
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-05-13 23:10:19 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

miwi@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-05-13 23:10:21 UTC
Maintainer of graphics/pear-Image_Graph,

Please note that PR ports/146555 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/146555

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2010-05-13 23:10:22 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Nick Hilliard 2010-05-14 10:12:38 UTC
I haven't used pear-Image_Graph for a couple of years, so can't test this.
 If someone else wants to take up maintainership of this package, please go
ahead.

Nick
Comment 5 Olli Hauer 2010-05-14 13:02:09 UTC
Please apply this second patch after the first one (to get rid off all those crlf).

--- patch2_pear-Image_Graph.txt begins here ---
--- Makefile
+++ Makefile
@@ -18,6 +18,7 @@
                 ${PEARDIR}/Image/Canvas.php:${PORTSDIR}/graphics/pear-Image_Canvas

  USE_PHP=       yes
+USE_DOS2UNIX=  yes

  CATEGORY=      Image
  FILES=         Graph.php Graph/Axis.php Graph/Common.php Graph/Config.php \
--- patch2_pear-Image_Graph.txt ends here ---
Comment 6 Martin Wilke freebsd_committer freebsd_triage 2010-05-15 06:18:38 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 7 dfilter service freebsd_committer freebsd_triage 2010-05-15 06:18:38 UTC
miwi        2010-05-15 05:18:25 UTC

  FreeBSD ports repository

  Modified files:
    graphics/pear-Image_Graph Makefile 
  Log:
  - Fix php53 issus
  - Take over maintainership
  
  PR:             146555
  Submitted by:   olli hauer <ohauer@gmx.de>
  Approved by:    Nick Hilliard <nick@foobar.org> (prev. maintainer)
  
  Revision  Changes    Path
  1.9       +18 -4     ports/graphics/pear-Image_Graph/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"