Bug 146897 - Recent patch to editors/emacs-nox11 causes 'make' to fail
Summary: Recent patch to editors/emacs-nox11 causes 'make' to fail
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ashish SHUKLA
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-24 02:00 UTC by phoffman
Modified: 2010-07-07 16:31 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description phoffman 2010-05-24 02:00:09 UTC 
	A few days ago, "Ashish SHUKLA" added a patch to editors/emacs-nox11/Makefile that causes make to die with:
"Makefile", line 14: Malformed conditional (${OSVERSION} < 700000 && defined(WITH_DBUS))
"Makefile", line 16: if-less endif
make: fatal errors encountered -- cannot continue

Fix: 

Remove the lines:
.if ${OSVERSION} < 700000 && defined(WITH_DBUS)
BROKEN= Does not currently build with dbus support
.endif

NOTE, however, even when backing out the patch, 'make' starts making with the config still having X11 support checked in the config dialog. It appears that something else is broken in emacs as well.
How-To-Repeat: 	cd /usr/ports/editors/emacs-nox11; make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-05-24 02:00:17 UTC 
Maintainer of editors/emacs-nox11,

Please note that PR ports/146897 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/146897

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-05-24 02:00:20 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Ashish SHUKLA freebsd_committer freebsd_triage 2010-06-18 16:46:07 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ashish

Track
Comment 4 Ashish SHUKLA freebsd_committer freebsd_triage 2010-06-18 16:57:30 UTC 
Hi Paul,

Can you please confirm that the problem reported in the PR is fixed for you ?

Thanks
-- 
Ashish SHUKLA

Sent via Gnus from GNU Emacs
Comment 5 Ashish SHUKLA freebsd_committer freebsd_triage 2010-07-07 16:31:34 UTC 
State Changed
From-To: feedback->closed

Submitter timeout.