Bug 147147 - [PATCH] www/mod_log_dbd: cleanups
Summary: [PATCH] www/mod_log_dbd: cleanups
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-apache (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-27 22:00 UTC by Philip M. Gollucci
Modified: 2010-08-31 02:16 UTC (History)
1 user (show)

See Also:

Attachments
ap22-mod_log_dbd-0.2_4.patch (1.34 KB, patch)
2010-05-27 22:00 UTC, Philip M. Gollucci 		no flags Details | Diff
smime.p7s (4.54 KB, application/pkcs7-signature)
2010-05-28 20:42 UTC, bfosdick 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philip M. Gollucci 2010-05-27 22:00:07 UTC 
- pet portlint
- use apxs not sed in pkg-plist
- apxs -a is install -A is uninistall
- bump portrevision

Port maintainer (bfoz@bfoz.net) is cc'd.

Generated with FreeBSD Port Tools 0.99
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-05-27 22:00:16 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->apache

apache@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-05-27 22:00:19 UTC 
Maintainer of www/mod_log_dbd,

Please note that PR ports/147147 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/147147

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2010-05-27 22:00:20 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 bfosdick 2010-05-28 20:42:27 UTC 
I used sed for @unexec to avoid polluting http.conf with a commented out LoadModule line, which IIRC was the recommended practice at the time. If using 'apxs -A' is the will of the ports team then I'm fine with the change.
Using 'apxs -A' for @exec prevents enabling the module before the admin has had a chance to properly configure it. If the module were enabled before properly configuring a target database there would be nowhere to write future log events to and they would consequently be discarded. It would appear to the admin that the server had mysteriously stopped logging. However, if it's the will of the ports team that modules be immediately enabled...

On May 27, 2010, at 23:00 , Edwin Groothuis wrote:

> Maintainer of www/mod_log_dbd,
> 
> Please note that PR ports/147147 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
> 
> The full text of the PR can be found at:
>    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/147147
> 
> -- 
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org
Comment 5 Philip M. Gollucci freebsd_committer freebsd_triage 2010-06-10 00:38:59 UTC 
State Changed
From-To: feedback->open

maintainer timeout 14 days
Comment 6 Philip M. Gollucci freebsd_committer freebsd_triage 2010-08-31 02:16:06 UTC 
State Changed
From-To: open->closed

since this is logging related, I agree with maintainer for now