comms/gnokii does not build. How-To-Repeat: # cd /usr/ports/comms/gnokii && make showconfig && make ===> The following configuration options are available for gnokii-0.6.29_1,1: ICAL=on "Build with IETF iCal support" USB=on "Build with libusb support" PCSC=on "Build with PC/SC-Lite support" SMSD=on "Enable smsd daemon" MYSQL=on "Enable MySQL support for smsd" PGSQL=on "Enable PostgreSQL support for smsd" X11=on "Build graphical version (xgnokii)" ===> Use 'make config' to modify these settings ===> License check disabled, port has not defined LICENSE ===> Found saved configuration for gnokii-0.6.29_1,1 ===> Extracting for gnokii-0.6.29_1,1 => MD5 Checksum OK for gnokii-0.6.29.tar.bz2. => SHA256 Checksum OK for gnokii-0.6.29.tar.bz2. ===> Patching for gnokii-0.6.29_1,1 ===> Applying FreeBSD patches for gnokii-0.6.29_1,1 ===> gnokii-0.6.29_1,1 depends on file: /usr/local/lib/perl5/site_perl/5.10.1/mach/XML/Parser.pm - found ===> gnokii-0.6.29_1,1 depends on executable: gmake - found ===> gnokii-0.6.29_1,1 depends on file: /usr/local/libdata/pkgconfig/xpm.pc - found ===> gnokii-0.6.29_1,1 depends on file: /usr/local/bin/intltool-extract - found ===> gnokii-0.6.29_1,1 depends on executable: pkg-config - found ===> gnokii-0.6.29_1,1 depends on shared library: ical.44 - found ===> gnokii-0.6.29_1,1 depends on shared library: pcsclite.1 - found ===> gnokii-0.6.29_1,1 depends on shared library: intl - found ===> gnokii-0.6.29_1,1 depends on shared library: mysqlclient.16 - found ===> gnokii-0.6.29_1,1 depends on shared library: pq.5 - found ===> gnokii-0.6.29_1,1 depends on shared library: atk-1.0.0 - found ===> gnokii-0.6.29_1,1 depends on shared library: glib-2.0.0 - found ===> gnokii-0.6.29_1,1 depends on shared library: gtk-x11-2.0.0 - found ===> gnokii-0.6.29_1,1 depends on shared library: pango-1.0.0 - found ===> Configuring for gnokii-0.6.29_1,1 .. /bin/sh ../../libtool --tag=CC --mode=compile cc -DCOMPILING_LIBGNOKII -I. -I../../include -I/usr/local/include -I/usr/local/include -I../../include -D_THREAD_SAFE -I/usr/local/include/PCSC -O2 -pipe -march=native -fno-strict-aliasing -Wall -Wno-pointer-sign -fvisibility=hidden -fno-strict-aliasing -MT libPHONES_la-pcsc.lo -MD -MP -MF .deps/libPHONES_la-pcsc.Tpo -c -o libPHONES_la-pcsc.lo `test -f 'pcsc.c' || echo './'`pcsc.c libtool: compile: cc -DCOMPILING_LIBGNOKII -I. -I../../include -I/usr/local/include -I/usr/local/include -I../../include -D_THREAD_SAFE -I/usr/local/include/PCSC -O2 -pipe -march=native -fno-strict-aliasing -Wall -Wno-pointer-sign -fvisibility=hidden -fno-strict-aliasing -MT libPHONES_la-pcsc.lo -MD -MP -MF .deps/libPHONES_la-pcsc.Tpo -c pcsc.c -fPIC -DPIC -o .libs/libPHONES_la-pcsc.o pcsc.c: In function 'get_gn_error': pcsc.c:202: error: 'SCARD_W_INSERTED_CARD' undeclared (first use in this function) pcsc.c:202: error: (Each undeclared identifier is reported only once pcsc.c:202: error: for each function it appears in.) gmake[2]: *** [libPHONES_la-pcsc.lo] Error 1 gmake[2]: *** Waiting for unfinished jobs.... mv -f .deps/libPHONES_la-gnapplet.Tpo .deps/libPHONES_la-gnapplet.Plo gmake[2]: Leaving directory `/usr/obj/usr/ports/comms/gnokii/work/gnokii-0.6.29/common/phones' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory `/usr/obj/usr/ports/comms/gnokii/work/gnokii-0.6.29/common' gmake: *** [all-recursive] Error 1 *** Error code 1 Stop in /usr/ports/comms/gnokii. *** Error code 1 Stop in /usr/ports/comms/gnokii.
Maintainer of comms/gnokii, Please note that PR ports/147288 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/147288 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Hi! The SCARD_W_INSERTED_CARD define was simply removed with no substitute from the pcsc-lite defines with the update to 1.6.0. [1] [2] I'm attaching a patch which fixes build by not checking for such a return code from pcsc(which reasonably should not return it back anymore not having defined it). This quick fix should be tested by someone using the pcsc gnokii functionality which I'm not able to test. Also already sent information and simple patch upstream. Added file: gnokii/files/patch-common-phones-pcsc.c [1] http://svn.debian.org/viewsvn/pcsclite/trunk/PCSC/src/PCSC/pcsclite.h.in?view=log [2] http://svn.debian.org/viewsvn/pcsclite/trunk/PCSC/src/PCSC/pcsclite.h.in?r1=4544&r2=4574 -- Guido Falsi <mad@madpilot.net>
Hi! > Also already sent information and simple patch upstream. Ok, I agree. But I would prefer the other patch attached.
On 06/05/10 02:20, Anatoly Borodin wrote: > Hi! > >> Also already sent information and simple patch upstream. > > Ok, I agree. But I would prefer the other patch attached. Yes, this one is cleaner. I did not think about it. I approve the patch. -- Guido Falsi <mad@madpilot.net>
State Changed From-To: feedback->open Newer patch approved.
miwi 2010-06-05 11:26:36 UTC FreeBSD ports repository Added files: comms/gnokii/files patch-common-phones-pcsc.c Log: - Fix build PR: 147288 Submitted by: Anatoly Borodin <anatoly.borodin@gmail.com> Approved by: maintianer Revision Changes Path 1.1 +12 -0 ports/comms/gnokii/files/patch-common-phones-pcsc.c (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!