Bug 147292 - [nfs] [patch] readahead missing in nfs client options filter list
Summary: [nfs] [patch] readahead missing in nfs client options filter list
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-fs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-01 18:00 UTC by Adam Nowacki
Modified: 2010-10-27 17:19 UTC (History)
0 users

See Also:

Attachments
file.diff (1.11 KB, patch)
2010-06-01 18:00 UTC, Adam Nowacki 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Nowacki 2010-06-01 18:00:09 UTC 
In sys/nfsclient/nfs_vfsops.c:
static const char *nfs_opts[] = { "from", "nfs_args",
    "noatime", "noexec", "suiddir", "nosuid", "nosymfollow", "union",
    "noclusterr", "noclusterw", "multilabel", "acls", "force", "update",
    "async", "dumbtimer", "noconn", "nolockd", "intr", "rdirplus", "resvport",
    "readdirsize", "soft", "hard", "mntudp", "tcp", "udp", "wsize", "rsize",
    "retrans", "acregmin", "acregmax", "acdirmin", "acdirmax", 
    "deadthresh", "hostname", "timeout", "addr", "fh", "nfsv3", "sec",
    "maxgroups", "principal",
    NULL };

this list is missing "readahead" option resulting in:
# /sbin/mount_nfs -o nfsv3,rw,async,noatime,noauto,mntudp,readahead=2,rsize=32768,wsize=32768 192.168.0.3:/mnt/ls0 /mnt/nfs/u1/mnt/ls0
mount_nfs: /mnt/nfs/u1/mnt/ls0, mount option <readahead> is unknown: Invalid argument

Fix: add "readahead" to the list of nfs options (nfs_opts), the rest of the code already appears to be there

Patch attached with submission follows:
How-To-Repeat: mount a nfs with -o readahead=1
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2010-06-04 03:30:11 UTC 
Responsible Changed
From-To: freebsd-bugs->freebsd-fs

Over to maintainer(s).
Comment 2 Jaakko Heinonen freebsd_committer freebsd_triage 2010-10-27 17:19:26 UTC 
State Changed
From-To: open->closed

Duplicate of 151321. Fixed in head (r214418).