Bug 147311 - emulators/snes9x-gtk does not recognize --with(out)-screenshot
Summary: emulators/snes9x-gtk does not recognize --with(out)-screenshot
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-02 09:10 UTC by David Demelier
Modified: 2010-06-29 08:50 UTC (History)
0 users

See Also:


Attachments
file.diff (717 bytes, patch)
2010-06-02 09:10 UTC, David Demelier
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Demelier 2010-06-02 09:10:01 UTC
The emulators/snes9x-gtk configure script does not recognize --with(out)-screenshot option. Maybe the snes9x-gtk developers didn't remove this option and it's enabled by default (if libpng is found)

Because snes9x-gtk need libpng, screenshot feature will be enabled in any case. I propose the complete removal of the SCREENSHOT option.

How-To-Repeat: cd /usr/ports/emulators/snes9x-gtk
make config
# uncheck screenshot

make configure

make config
# check screenshot

make configure 

see : configure: WARNING: unrecognized options: --with-screenshot
see : configure: WARNING: unrecognized options: --without-screenshot
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-06-02 09:10:09 UTC
Maintainer of emulators/snes9x-gtk,

Please note that PR ports/147311 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/147311

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-06-02 09:10:11 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 dfilter service freebsd_committer freebsd_triage 2010-06-29 08:49:08 UTC
stefan      2010-06-29 07:48:59 UTC

  FreeBSD ports repository

  Modified files:
    emulators/snes9x-gtk Makefile 
  Log:
  Remove screenshot option, which is unconditionally enabled, anyway.
  
  PR:             147311
  Submitted by:   Demelier David <demelier.david@gmail.com>
  Approved by:    maintainer timeout (>3 weeks)
  Feature safe:   yes
  
  Revision  Changes    Path
  1.6       +0 -8      ports/emulators/snes9x-gtk/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Stefan Walter freebsd_committer freebsd_triage 2010-06-29 08:49:18 UTC
State Changed
From-To: feedback->closed

Committed, thanks!