Bug 148234 - pkg_install fails for some math/octave-forge ports
Summary: pkg_install fails for some math/octave-forge ports
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-29 18:00 UTC by Stephen Montgomery-Smith
Modified: 2011-03-17 17:20 UTC (History)
0 users

See Also:

Attachments
ddd (555 bytes, text/plain)
2011-01-13 20:43 UTC, Stephen Montgomery-Smith 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Montgomery-Smith 2010-06-29 18:00:20 UTC 
The more recent octave-forge-* ports don't pkg_install from their packages.  This seems to be a problem that the octave forge packagng process is expecting gnu-make.

Fix: 

25a26
> RUN_DEPENDS+=	gmake:${PORTSDIR}/devel/gmake
42c43
< 	@${ECHO_CMD} "@exec octave -H -q --no-site-file --eval \"pkg('install','${LOCALBASE}/share/octave/tarballs/${DISTNAME}.tar.gz')\" > /dev/null" >> ${TMPPLIST}
---
> 	@${ECHO_CMD} "@exec env MAKE=gmake octave -H -q --no-site-file --eval \"pkg('install','${LOCALBASE}/share/octave/tarballs/${DISTNAME}.tar.gz')\" > /dev/null" >> ${TMPPLIST}
Comment 1 Mark Linimon 2010-06-30 06:28:41 UTC 
Which port or ports does this patch apply to?

mcl
Comment 2 Stephen Montgomery-Smith 2010-06-30 06:34:47 UTC 
Mark Linimon wrote:
> Which port or ports does this patch apply to?
>
> mcl

I didn't make a complete list of ports this applies to.

But octave-forge-specfun is an example of a port that is fixed by this 
patch.

Do
make install package; make deinstall; pkg_add octave-forge-specfun*.tar.bz2
should show the difficulty.
Comment 3 Stephen Montgomery-Smith 2010-06-30 06:52:19 UTC 
Mark Linimon wrote:
> Which port or ports does this patch apply to?
>
> mcl

OK, my mistake - to reproduce this error do the following:

cd /usr/ports/math/octave-forge-specfun
make install package
pkg_delete gmake-3.81_4 (or whatever version you have installed)
pkg_add octave-forge-specfun-1.0.9.tbz

In other words, pkg_add requires the presence of gmake for this port to 
be installed as a package.
Comment 4 Stephen Montgomery-Smith 2011-01-13 13:27:40 UTC 
Actually, it seems that all that is needed to fix this bug is to add the 
line:

RUN_DEPENDS+= gmake:${PORTSDIR}/devel/gmake

to the file ports/Mk/bsd.octave.mk

(Looking at the original submission, it seems that I omitted the name of 
the file that needs to be patched!  I'll try to resubmit a proper patch 
later today.)
Comment 5 Stephen Montgomery-Smith 2011-01-13 20:43:32 UTC 
Here is the patch done properly.

As I said, it is necessary for gmake to be a RUNS_DEPENDS for the 
octave-forge ports.  Without this, the packages will not install correctly.
Comment 6 Martin Wilke freebsd_committer freebsd_triage 2011-03-17 17:14:18 UTC 
State Changed
From-To: open->closed

Committed. Thanks!
Comment 7 dfilter service freebsd_committer freebsd_triage 2011-03-17 17:14:22 UTC 
miwi        2011-03-17 17:14:09 UTC

  FreeBSD ports repository

  Modified files:
    Mk                   bsd.octave.mk 
  Log:
  - Add gmake as RUN_DEP
  
  PR:             148234
  Submitted by:   Stephen Montgomery-Smith <stephen@missouri.edu> (maintainer)
  
  Revision  Changes    Path
  1.11      +3 -2      ports/Mk/bsd.octave.mk
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"