Bug 148235 - Supress noisy, always fail test condition in devel/xdg-utils
Supress noisy, always fail test condition in devel/xdg-utils
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Any Any
: Normal Affects Only Me
Assigned To: gnome
Depends on:
  Show dependency treegraph
Reported: 2010-06-29 18:00 UTC by jsa
Modified: 2010-07-25 15:30 UTC (History)
0 users

See Also:

file.diff (485 bytes, patch)
2010-06-29 18:00 UTC, jsa
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jsa 2010-06-29 18:00:20 UTC
xdg-screensaver performs a check for `mv -T` to safely move lockfiles to /tmp. FreeBSD does not support the -T switch, which causes mv to complain and spit out a usage example.

If an app is run from the console (such as vlc), when calls to xdg-screensaver are made, it spews this error information to the terminal, possibly leading the user to believe the application is attempting to misappropriately move their data.

Fix: This patch (which should just be inserted into ${FILESDIR}) comments out the offending test condition and replaces it with the `false` command to essentially skip to the else condition without noisy error messages.

IMPORTANT: You must remove the .txt extension required by web based pr interface.

Patch attached with submission follows:
How-To-Repeat: Run multimedia/vlc from a terminal, opening any video multimedia type. Watch for scary message that the app failed to `mv` something...
Comment 1 Koop Mast freebsd_committer 2010-06-29 18:13:58 UTC
Responsible Changed
From-To: freebsd-bugs->gnome

This is a port pr, assing to gnome.
Comment 2 Koop Mast freebsd_committer 2010-06-29 18:32:05 UTC
State Changed
From-To: open->patched

Will be committed after 8.1-R is out.
Comment 3 Koop Mast freebsd_committer 2010-07-25 15:23:25 UTC
State Changed
From-To: patched->closed

Committed thanks.
Comment 4 dfilter freebsd_committer 2010-07-25 15:23:30 UTC
kwm         2010-07-25 14:23:22 UTC

  FreeBSD ports repository

  Modified files:
    devel/xdg-utils      Makefile 
  Added files:
    devel/xdg-utils/files patch-scripts_xdg-screensaver 
  mv on FreeBSD doesn't support the -T switch. Patch out the usage of it.
  PR:             ports/148235
  Submitted by:   "Joseph S. Atkinson" <jsa@wickedmachine.net>
  Revision  Changes    Path
  1.10      +2 -2      ports/devel/xdg-utils/Makefile
  1.1       +16 -0     ports/devel/xdg-utils/files/patch-scripts_xdg-screensaver (new)
cvs-all@freebsd.org mailing list
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"