Bug 148263 - emulators/virtualbox-ose-additions fails to compile without X11.
Summary: emulators/virtualbox-ose-additions fails to compile without X11.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Beat Gaetzi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-30 17:00 UTC by Vick Khera
Modified: 2010-07-02 12:11 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vick Khera 2010-06-30 17:00:19 UTC
	

upgrading to the latest virtualbox-ose-additions port fails to build on a
system without X11 installed, even if the X11 option is set to off.

% make showconfig
===> The following configuration options are available for virtualbox-ose-additions-3.2.6:
     DEBUG=off "Build with debugging symbols"
     X11=off "Build with X11 support"
     HAL=off "Install HAL policy file for additions"
     OPENGL=off "Build with OpenGL support"

Later in the build, it fails with this error:

kBuild: Compiling VBoxGuestR3LibXFree86 - /var/tmp/n/yertle1/sources/ports/emulators/virtualbox-ose-additions/work/VirtualBox-3.2.6_OSE/src/VBox/Additions/common/VBoxGuestLib/VBoxGuestR3LibRuntimeXF86.cpp
In file included from /var/tmp/n/yertle1/sources/ports/emulators/virtualbox-ose-additions/work/VirtualBox-3.2.6_OSE/src/VBox/Additions/x11/x11include/4.3/programs/Xserver/hw/xfree86/os-support/xf86_ansic.h:90,
                 from /var/tmp/n/yertle1/sources/ports/emulators/virtualbox-ose-additions/work/VirtualBox-3.2.6_OSE/src/VBox/Additions/common/VBoxGuestLib/VBoxGuestR3LibRuntimeXF86.cpp:39:
/var/tmp/n/yertle1/sources/ports/emulators/virtualbox-ose-additions/work/VirtualBox-3.2.6_OSE/src/VBox/Additions/x11/x11include/4.3/programs/Xserver/include/misc.h:119:57: error: X11/Xfuncs.h: No such file or directory
kmk: *** [/var/tmp/n/yertle1/sources/ports/emulators/virtualbox-ose-additions/work/VirtualBox-3.2.6_OSE/out/freebsd.x86/release/obj/VBoxGuestR3LibXFree86/VBoxGuestR3LibRuntimeXF86.o] Error 1
The failing command:
@c++ -c -O2 -g -pipe -pedantic -Wshadow -Wall -Wextra
-Wno-missing-field-initializers -Wno-unused -Wno-trigraphs
-fdiagnostics-show-option -Wno-long-long -Wno-variadic-macros
-march=i586 -O2 -mtune=generic -fno-omit-frame-pointer
-fno-strict-aliasing -fvisibility=hidden -DVBOX_HAVE_VISIBILITY_HIDDEN
-DRT_USE_VISIBILITY_DEFAULT -fvisibility-inlines-hidden
-fno-exceptions -m32 -Wno-shadow
-I/var/tmp/n/yertle1/sources/ports/emulators/virtualbox-ose-additions/work/VirtualBox-3.2.6_OSE/src/VBox/Additions/x11/x11include/4.3/programs/Xserver/hw/xfree86/common/
-I/var/tmp/n/yertle1/sources/ports/emulators/virtualbox-ose-additions/work/VirtualBox-3.2.6_OSE/src/VBox/Additions/x11/x11include/4.3/programs/Xserver/hw/xfree86/os-support
-I/var/tmp/n/yertle1/sources/ports/emulators/virtualbox-ose-additions/work/VirtualBox-3.2.6_OSE/src/VBox/Additions/x11/x11include/4.3/programs/Xserver/include
-I/var/tmp/n/yertle1/sources/ports/emulators/virtualbox-ose-additions/work/VirtualBox-3.2.6_OSE/src/VBox/Additions/x11/x11include/4.3/include
-I/var/tmp/n/yertle1/sources/ports/emulators/virtualbox-ose-additions/work/VirtualBox-3.2.6_OSE/src/VBox/Additions/x11/x11include/4.3/exports/include/X11
-I/usr/include -I/usr/X11R6/include -I/usr/local/include
-I/var/tmp/n/yertle1/sources/ports/emulators/virtualbox-ose-additions/work/VirtualBox-3.2.6_OSE/include
-I/var/tmp/n/yertle1/sources/ports/emulators/virtualbox-ose-additions/work/VirtualBox-3.2.6_OSE/out/freebsd.x86/release
-DVBOX -DVBOX_OSE -DVBOX_WITH_64_BITS_GUESTS -DVBOX_WITH_HARDENING
-DRTPATH_APP_PRIVATE=\"/usr/local/lib/virtualbox\" -DRT_OS_FREEBSD
-D__FREEBSD__ -DRT_ARCH_X86 -D__X86__ -DIN_RING3 -DHC_ARCH_BITS=32
-DGC_ARCH_BITS=64 -DIN_GUEST -DIN_GUEST_R3 -DIN_RT_R3 -DVBOX_WITH_HGCM
-DVBOX_VBGLR3_XFREE86 -DRTMEM_NO_WRAP_TO_EF_APIS
-DVBOX_WITH_GUEST_PROPS
-Wp,-MD,/var/tmp/n/yertle1/sources/ports/emulators/virtualbox-ose-additions/work/VirtualBox-3.2.6_OSE/out/freebsd.x86/release/obj/VBoxGuestR3LibXFree86/VBoxGuestR3LibRuntimeXF86.o.dep
-Wp,-MT,/var/tmp/n/yertle1/sources/ports/emulators/virtualbox-ose-additions/work/VirtualBox-3.2.6_OSE/out/freebsd.x86/release/obj/VBoxGuestR3LibXFree86/VBoxGuestR3LibRuntimeXF86.o
-Wp,-MP -o
/var/tmp/n/yertle1/sources/ports/emulators/virtualbox-ose-additions/work/VirtualBox-3.2.6_OSE/out/freebsd.x86/release/obj/VBoxGuestR3LibXFree86/VBoxGuestR3LibRuntimeXF86.o
/var/tmp/n/yertle1/sources/ports/emulators/virtualbox-ose-additions/work/VirtualBox-3.2.6_OSE/src/VBox/Additions/common/VBoxGuestLib/VBoxGuestR3LibRuntimeXF86.cpp
*** Error code 2

Stop in /n/yertle1/sources/ports/emulators/virtualbox-ose-additions.
*** Error code 1

Fix: 

don't know. it worked in the prior version, 3.1.51.r25618_3.
How-To-Repeat: 
configure port to build without X11, and uninstall X11 libraries.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2010-07-01 00:16:06 UTC
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-emulation

Fix synopsis and assign.
Comment 2 Beat Gaetzi freebsd_committer freebsd_triage 2010-07-01 14:02:29 UTC
Responsible Changed
From-To: freebsd-emulation->beat

I'll take it.
Comment 3 Beat Gaetzi freebsd_committer freebsd_triage 2010-07-01 14:03:47 UTC
Hi,

Could you please try this patch:
http://people.freebsd.org/~beat/patches/vbox/virtualbox-ose-additions-nox11.patch

Thanks,
Beat
Comment 4 Vick Khera 2010-07-01 15:01:29 UTC
perfect.  worked great. thanks!

On Thu, Jul 1, 2010 at 9:03 AM, Beat Gaetzi <beat@freebsd.org> wrote:
> Hi,
>
> Could you please try this patch:
> http://people.freebsd.org/~beat/patches/vbox/virtualbox-ose-additions-nox11.patch
>
> Thanks,
> Beat
>
Comment 5 dfilter service freebsd_committer freebsd_triage 2010-07-02 12:06:42 UTC
beat        2010-07-02 11:06:28 UTC

  FreeBSD ports repository

  Added files:
    emulators/virtualbox-ose-additions/files 
                                             patch-src-VBox-Additions-common-VBoxGuestLib-Makefile.kmk 
  Log:
  - Fix build with X11 support disabled
  
  PR:             ports/148263
  Reported by:    Vivek Khera <vivek AT khera.org>
  Feature safe:   yes
  
  Revision  Changes    Path
  1.1       +18 -0     ports/emulators/virtualbox-ose-additions/files/patch-src-VBox-Additions-common-VBoxGuestLib-Makefile.kmk (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Beat Gaetzi freebsd_committer freebsd_triage 2010-07-02 12:11:27 UTC
State Changed
From-To: open->closed

Committed. Thanks!