Bug 148329 - shells/bash broken requires libiconv
Summary: shells/bash broken requires libiconv
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-02 20:20 UTC by Garrett Wollman
Modified: 2010-08-06 09:50 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Garrett Wollman 2010-07-02 20:20:03 UTC
shells/bash has an unhandled dependency on libiconv.

Fix: 

Make shells/bash depend on converters/libiconv, or else fix the broken
vendor makefile to not link against libiconv when configure doesn't
find it.  It builds just fine without it.
How-To-Repeat: Attempt to build shells/bash on a machine with no libiconv.  Watch it
fail:

[root@ca /usr/ports/shells/bash]# make
===>  Building for bash-4.1.7
rm -f bash
cc -L./builtins -L./lib/readline -L./lib/readline -L./lib/glob  -L./lib/tilde  -L./lib/sh -L/usr/local/lib  -rdynamic  -O -pipe -o bash shell.o eval.o y.tab.o general.o make_cmd.o print_cmd.o   dispose_cmd.o execute_cmd.o variables.o copy_cmd.o error.o  expr.o flags.o jobs.o subst.o hashcmd.o hashlib.o mailcheck.o  trap.o input.o unwind_prot.o pathexp.o sig.o test.o version.o  alias.o array.o arrayfunc.o assoc.o braces.o bracecomp.o bashhist.o  bashline.o  list.o stringlib.o locale.o findcmd.o redir.o  pcomplete.o pcomplib.o syntax.o xmalloc.o  -lbuiltins -lglob -lsh -lreadline -lhistory -ltermcap  -ltilde   -liconv 
/usr/bin/ld: cannot find -liconv
*** Error code 1
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-07-02 20:20:19 UTC
Responsible Changed
From-To: freebsd-ports-bugs->obrien

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2010-08-06 09:49:01 UTC
ehaupt      2010-08-06 08:48:46 UTC

  FreeBSD ports repository

  Modified files:
    shells/bash          Makefile 
  Log:
  - Depend on libiconv in order to fix package installation
  - Bump PORTREVISION
  
  PR:             147747, 148329, 149218
  Submitted by:   Alex Goncharov <alex-goncharov@comcast.net>,
                  Garrett Wollman <wollman@khavrinen.csail.mit.edu>
                  yar
  Approved by:    obrien (maintainer timeout; > 50 days)
  
  Revision  Changes    Path
  1.123     +2 -1      ports/shells/bash/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Emanuel Haupt freebsd_committer freebsd_triage 2010-08-06 09:49:25 UTC
Responsible Changed
From-To: obrien->ehaupt

I will take care of it.
Comment 4 Emanuel Haupt freebsd_committer freebsd_triage 2010-08-06 09:49:59 UTC
State Changed
From-To: open->closed

Committed, thanks!