on deinstall this port unconditionally deletes the configfile, fix this by adding some pkg-plist magic Added file(s): - pkg-plist Port maintainer (melifaro@ipfw.ru) is cc'd. Generated with FreeBSD Port Tools 0.99 Fix: do not delete igmpproxy.conf if it is different then igmpproxy.conf.sample
Responsible Changed From-To: freebsd-ports-bugs->miwi miwi@ wants his PRs (via the GNATS Auto Assign Tool)
Maintainer of net/igmpproxy, Please note that PR ports/149547 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/149547 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Florian Smeets <flo@kasimir.com> writes: > @@ -0,0 +1,3 @@ > +sbin/igmpproxy > +@unexec if cmp -s %D/etc/igmpproxy.conf.sample %D/etc/igmpproxy.conf; then rm -f %D/etc/igmpproxy.conf; fi > +etc/igmpproxy.conf.sample I think you're missing @exec to complement @unexec. Add the line below to the end of plist. @exec if [ ! -f %D/etc/igmpproxy.conf ]; then cp -p %D/%F %B/igmpproxy.conf; fi
On 12.08.10 14:11, Anonymous wrote: > Florian Smeets<flo@kasimir.com> writes: > >> @@ -0,0 +1,3 @@ >> +sbin/igmpproxy >> +@unexec if cmp -s %D/etc/igmpproxy.conf.sample %D/etc/igmpproxy.conf; then rm -f %D/etc/igmpproxy.conf; fi >> +etc/igmpproxy.conf.sample > Hi, > I think you're missing @exec to complement @unexec. Add the line below > to the end of plist. > > @exec if [ ! -f %D/etc/igmpproxy.conf ]; then cp -p %D/%F %B/igmpproxy.conf; fi i was thinking about the @exec too, but i don't think you need an @exec for every @unexec, and everything works as expected without the @exec. The port automatically installs igmpproxy.conf and igmpproxy.conf.sample, so IMHO we only need the @unexec in the plist. Cheers, Florian
Florian Smeets <flo@kasimir.com> writes: >> I think you're missing @exec to complement @unexec. Add the line below >> to the end of plist. >> >> @exec if [ ! -f %D/etc/igmpproxy.conf ]; then cp -p %D/%F %B/igmpproxy.conf; fi > > i was thinking about the @exec too, but i don't think you need an > @exec for every @unexec, and everything works as expected without the > @exec. The @exec line is needed when installing from package, not port.
On 12.08.10 14:45, Anonymous wrote: > Florian Smeets<flo@kasimir.com> writes: > >>> I think you're missing @exec to complement @unexec. Add the line below >>> to the end of plist. >>> >>> @exec if [ ! -f %D/etc/igmpproxy.conf ]; then cp -p %D/%F %B/igmpproxy.conf; fi >> >> i was thinking about the @exec too, but i don't think you need an >> @exec for every @unexec, and everything works as expected without the >> @exec. > > The @exec line is needed when installing from package, not port. Oh, i did not know that. Thanks for bringing it to my attention! I've attached the new complete patch. Cheers, Florian
Responsible Changed From-To: miwi->freebsd-ports-bugs back to pool.
Responsible Changed From-To: freebsd-ports-bugs->rene Grab, related to ports/150146
rene 2010-10-31 14:47:29 UTC FreeBSD ports repository Modified files: net/igmpproxy Makefile net/igmpproxy/files igmpproxy.in Added files: net/igmpproxy pkg-plist Log: - Do not delete the configuration file on deinstall if it was modified [1] - For the rc script: [2] - use /usr/sbin/daemon to start the rc script because igmpproxy does not daemonize itself - add shutdown keyword - cleanups - Bump PORTREVISION [2] PR: ports/149547 [1], ports/150146 [2] Submitted by: Florian Smeets [flo kasimir.com] [1] [2] Approved by: maintainer timeout (11 weeks [1], 8 weeks [2]) Revision Changes Path 1.5 +1 -4 ports/net/igmpproxy/Makefile 1.3 +12 -3 ports/net/igmpproxy/files/igmpproxy.in 1.1 +4 -0 ports/net/igmpproxy/pkg-plist (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Commited, thanks