Bug 149765 - [PATCH] audio/faac: improve build patches
Summary: [PATCH] audio/faac: improve build patches
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-multimedia mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-18 14:30 UTC by Andriy Gapon
Modified: 2011-03-18 09:50 UTC (History)
1 user (show)

See Also:


Attachments
faac-1.28_1.patch (2.81 KB, patch)
2010-08-18 14:30 UTC, Andriy Gapon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Gapon 2010-08-18 14:30:03 UTC
1. fix portlint complaint about incorrect whitespace in CONFIGURE_ARGS assignment
2. instead of unconditionally setting LIBS in CONFIGURE_ENV use automake logic
   to correctly set library dependencies for the case when external libmp4v2 is used

Fix #2 also fixes build with non-base gcc: configure stage would pass LIBS to all
invocations of gcc and linking would fail because libmp4v2 is a C++ library, but
non-base gcc (as opposed to g++) doesn't know where to look for the correct
libstdc++.

Added file(s):
- files/patch-frontend_Makefile.am
I think that this patch could be proposed to the upstream developers for inclusion.

Port maintainer (multimedia@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99
Comment 1 Edwin Groothuis freebsd_committer 2010-08-18 14:30:19 UTC
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-multimedia

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2011-03-18 09:44:55 UTC
miwi        2011-03-18 09:44:41 UTC

  FreeBSD ports repository

  Modified files:
    audio/faac           Makefile distinfo 
    audio/faac/files     patch-configure.in 
  Added files:
    audio/faac/files     patch-frontend_Makefile.am 
  Log:
  1. fix portlint complaint about incorrect whitespace in CONFIGURE_ARGS
      assignment
  2. instead of unconditionally setting LIBS in CONFIGURE_ENV use automake logc
     to correctly set library dependencies for the case when external libmp4v2
     is used
  
  Fix #2 also fixes build with non-base gcc: configure stage would pass LIBS
  to all invocations of gcc and linking would fail because libmp4v2 is a C++
  library, but non-base gcc (as opposed to g++) doesn't know where to look
  for the correct libstdc++.
  
  PR:             149765
  Submitted by:   Andriy Gapon <avg@icyb.net.ua>
  
  Revision  Changes    Path
  1.43      +2 -3      ports/audio/faac/Makefile
  1.6       +0 -1      ports/audio/faac/distinfo
  1.3       +9 -3      ports/audio/faac/files/patch-configure.in
  1.1       +14 -0     ports/audio/faac/files/patch-frontend_Makefile.am (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Martin Wilke freebsd_committer 2011-03-18 09:45:05 UTC
State Changed
From-To: open->closed

Committed. Thanks!