Bug 152076 - [patch] databases/mysql51-server: Remove lib/mysql/plugin directory when built with BUILD_STATIC knob
[patch] databases/mysql51-server: Remove lib/mysql/plugin directory when buil...
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: Alex Dupre
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-09 13:10 UTC by jarrod
Modified: 2010-11-23 08:30 UTC (History)
0 users

See Also:


Attachments
databases-mysql51-server-pkg-plist.diff (426 bytes, patch)
2010-11-09 13:10 UTC, jarrod
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jarrod 2010-11-09 13:10:09 UTC
When built with the BUILD_STATIC knob, plugins are compiled statically in to the
mysqld binary, however, the installation process still creates the plugin
directory.  This directory remains empty and is not removed when the package is
deinstalled due to the expansion of %%PLUGINS%% to @comment.

===>  Installing for mysql-server-5.1.52
===>   mysql-server-5.1.52 depends on shared library: mysqlclient.16 - found
===>   Generating temporary packing list
===>  Checking if databases/mysql51-server already installed
===> Creating users and/or groups.
Using existing group `mysql'.
Using existing user `mysql'.
[removed]
Making install in archive
test -z "/usr/local/lib/mysql/plugin" || ../.././install-sh -c -d "/usr/local/lib/mysql/plugin"
Making install in blackhole
test -z "/usr/local/lib/mysql/plugin" || ../.././install-sh -c -d "/usr/local/lib/mysql/plugin"
Making install in csv
test -z "/usr/local/lib/mysql" || ../.././install-sh -c -d "/usr/local/lib/mysql"
Making install in federated
test -z "/usr/local/lib/mysql/plugin" || ../.././install-sh -c -d "/usr/local/lib/mysql/plugin"
Making install in heap
test -z "/usr/local/lib/mysql" || ../.././install-sh -c -d "/usr/local/lib/mysql"
 install  -o root -g wheel -m 444 'libheap.a' '/usr/local/lib/mysql/libheap.a'
 ranlib '/usr/local/lib/mysql/libheap.a'
Making install in innobase
test -z "/usr/local/lib/mysql/plugin" || ../.././install-sh -c -d "/usr/local/lib/mysql/plugin"

Though there is nothing to install in the above output, install-sh appears to
still create the directory.

Fix: Patch supplied.
How-To-Repeat: bender#	cd /usr/ports/databases/mysql51-server
bender#	make install clean BUILD_STATIC=YES
bender#	make deinstall
bender#	find /usr/local/lib/mysql/plugin
/usr/local/lib/mysql/plugin
bender#
Comment 1 Edwin Groothuis freebsd_committer 2010-11-09 13:10:17 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ale

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter freebsd_committer 2010-11-23 08:29:39 UTC
ale         2010-11-23 08:29:34 UTC

  FreeBSD ports repository

  Modified files:
    databases/mysql51-server Makefile distinfo pkg-plist 
  Log:
  Update to 5.1.53 release.
  Fix plist when BUILD_STATIC is set. [1]
  
  PR:             ports/152076 [1]
  Submitted by:   Jarrod Sayers <jarrod@downtools.com.au>
  
  Revision  Changes    Path
  1.271     +1 -1      ports/databases/mysql51-server/Makefile
  1.130     +2 -2      ports/databases/mysql51-server/distinfo
  1.88      +1 -1      ports/databases/mysql51-server/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Alex Dupre freebsd_committer 2010-11-23 08:30:27 UTC
State Changed
From-To: open->closed

Fixed, thanks!