Since rev 1.656 the pkg-message will no longer displayed during package install. How-To-Repeat: Build a package that displays a pkg-message, deinstall and then install the fresh created package. Revert to bsd.port.mk rev 1.655 do the same procedure the message will be displaed again during package install.
Responsible Changed From-To: freebsd-ports-bugs->portmgr bsd.port.mk is portmgr territory (via the GNATS Auto Assign Tool)
Can you try out this "hack" to see if it works for you and have no ill side-effects? Index: bsd.port.mk =================================================================== RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v retrieving revision 1.657 diff -a -u -r1.657 bsd.port.mk --- bsd.port.mk 27 Nov 2010 17:42:46 -0000 1.657 +++ bsd.port.mk 28 Nov 2010 15:09:51 -0000 @@ -5931,6 +5931,7 @@ fi; \ if [ -f ${PKGMESSAGE} ]; then \ ${CP} ${PKGMESSAGE} ${PKG_DBDIR}/${PKGNAME}/+DISPLAY; \ + ${ECHO_CMD} "@display +DISPLAY" >> ${PKG_DBDIR}/${PKGNAME}/+CONTENTS; \ fi; \ for dep in `${PKG_INFO} -qf ${PKGNAME} | ${AWK} '/^@pkgdep / {print $$2}' | ${SORT} -u`; do \ if [ -d ${PKG_DBDIR}/$$dep -a -z `${ECHO_CMD} $$dep | ${GREP} -E ${PKG_IGNORE_DEPENDS}` ]; then \ -- -- Pav Lucistnik <pav@oook.cz> <pav@FreeBSD.org> As I understand it the M25 marks the border between culture and agriculture.
I can reproduce this using only pkg_create -b and pkg_add. The created package contains the message in the file +DISPLAY, but pkg_add does not display it. It seems reasonable to me the @display entry should be created with the /var/db/pkg entry, so I actually consider the /hack/ a clean solution. After all the fake-pkg: target is to my knowledge the single point of creation for /var/db/pkg entries. The original way of handling this in the package: target seems less clean to me. Regards, Dominic
Just tested the patch, works for me! I feel kinda guilty for not recognizing the problem. I'd been using the patch in ports/144164 for a /very/ long time without recognizing this. The NO_INSTALL issue only affected 5 ports, cups being the only popular one (and I don't use cups), but I consider this issue more serious. Regards, Dominic
> I feel kinda guilty for not recognizing the problem. I'd been > using the patch in ports/144164 for a /very/ long time without > recognizing this. Sometimes also the generated package should be tested ;) The fix works for me. Thanks!
> Just tested the patch, works for me! > > I feel kinda guilty for not recognizing the problem. I'd been > using the patch in ports/144164 for a /very/ long time without > recognizing this. > Sometimes also the generated package should be tested ;) The patch works for me, thanks!
Responsible Changed From-To: portmgr->pav Take for exp-run
State Changed From-To: open->closed Patch committed
pav 2010-11-30 21:36:42 UTC FreeBSD ports repository Modified files: Mk bsd.port.mk Log: - Add a hack to display pkg-message on package install on packages created with pkg_create -b PR: ports/152626 Reported by: ohauer Revision Changes Path 1.658 +2 -1 ports/Mk/bsd.port.mk _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"