Bug 152626 - MK/bsd.port.mk since rev 1.656 pkg-message is no longer displayed if installed from package
Summary: MK/bsd.port.mk since rev 1.656 pkg-message is no longer displayed if installe...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pav Lucistnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-28 00:20 UTC by Olli Hauer
Modified: 2010-11-30 21:40 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Olli Hauer freebsd_committer freebsd_triage 2010-11-28 00:20:11 UTC
Since rev 1.656 the pkg-message will no longer displayed
during package install.

How-To-Repeat: Build a package that displays a pkg-message, deinstall
and then install the fresh created package.

Revert to bsd.port.mk rev 1.655 do the same procedure
the message will be displaed again during package install.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-11-28 00:20:18 UTC
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

bsd.port.mk is portmgr territory (via the GNATS Auto Assign Tool)
Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2010-11-28 15:11:44 UTC
Can you try out this "hack" to see if it works for you and have no ill
side-effects?

Index: bsd.port.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.657
diff -a -u -r1.657 bsd.port.mk
--- bsd.port.mk	27 Nov 2010 17:42:46 -0000	1.657
+++ bsd.port.mk	28 Nov 2010 15:09:51 -0000
@@ -5931,6 +5931,7 @@
 		fi; \
 		if [ -f ${PKGMESSAGE} ]; then \
 			${CP} ${PKGMESSAGE} ${PKG_DBDIR}/${PKGNAME}/+DISPLAY; \
+			${ECHO_CMD} "@display +DISPLAY" >> ${PKG_DBDIR}/${PKGNAME}/+CONTENTS; \
 		fi; \
 		for dep in `${PKG_INFO} -qf ${PKGNAME} | ${AWK} '/^@pkgdep / {print $$2}' | ${SORT} -u`; do \
 			if [ -d ${PKG_DBDIR}/$$dep -a -z `${ECHO_CMD} $$dep | ${GREP} -E ${PKG_IGNORE_DEPENDS}` ]; then \

-- 
-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>
As I understand it the M25 marks the border between culture and
agriculture.
Comment 3 kamikaze 2010-11-28 16:55:02 UTC
I can reproduce this using only pkg_create -b and pkg_add.

The created package contains the message in the file +DISPLAY,
but pkg_add does not display it. It seems reasonable to me the
@display entry should be created with the /var/db/pkg entry, so
I actually consider the /hack/ a clean solution.

After all the fake-pkg: target is to my knowledge the single point
of creation for /var/db/pkg entries. The original way of handling
this in the package: target seems less clean to me.

Regards,
Dominic
Comment 4 kamikaze 2010-11-28 17:05:41 UTC
Just tested the patch, works for me!

I feel kinda guilty for not recognizing the problem. I'd been
using the patch in ports/144164 for a /very/ long time without
recognizing this.

The NO_INSTALL issue only affected 5 ports, cups being the
only popular one (and I don't use cups), but I consider this
issue more serious.

Regards,
Dominic
Comment 5 Olli Hauer 2010-11-28 20:11:32 UTC
> I feel kinda guilty for not recognizing the problem. I'd been
> using the patch in ports/144164 for a /very/ long time without
> recognizing this.

Sometimes also the generated package should be tested ;)

The fix works for me.

Thanks!
Comment 6 Olli Hauer freebsd_committer freebsd_triage 2010-11-28 20:39:38 UTC
> Just tested the patch, works for me!
> 
> I feel kinda guilty for not recognizing the problem. I'd been
> using the patch in ports/144164 for a /very/ long time without
> recognizing this.
> 

Sometimes also the generated package should be tested ;)

The patch works for me, thanks!
Comment 7 Pav Lucistnik freebsd_committer freebsd_triage 2010-11-29 08:48:14 UTC
Responsible Changed
From-To: portmgr->pav

Take for exp-run
Comment 8 Pav Lucistnik freebsd_committer freebsd_triage 2010-11-30 21:36:00 UTC
State Changed
From-To: open->closed

Patch committed
Comment 9 dfilter service freebsd_committer freebsd_triage 2010-11-30 21:36:47 UTC
pav         2010-11-30 21:36:42 UTC

  FreeBSD ports repository

  Modified files:
    Mk                   bsd.port.mk 
  Log:
  - Add a hack to display pkg-message on package install on packages created with
    pkg_create -b
  
  PR:             ports/152626
  Reported by:    ohauer
  
  Revision  Changes    Path
  1.658     +2 -1      ports/Mk/bsd.port.mk
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"