Bug 153165 - port dns/ldns fails to build with config (EXAMPLES=on and GOST=off)
Summary: port dns/ldns fails to build with config (EXAMPLES=on and GOST=off)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-15 04:40 UTC by eli
Modified: 2010-12-20 21:50 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description eli 2010-12-15 04:40:07 UTC
When using the configuration options EXAMPLES=on and GOST=off, the port will not build.
This is due to the 'post-configure' section in the WITH_EXAMPLES if block.

post-configure:
        @(cd ${WRKSRC}/examples; ./configure --prefix=${PREFIX} \
                --infodir=${PREFIX}/${INFO_PATH} --mandir=${MANPREFIX}/man \
                --build=${CONFIGURE_TARGET})

This section does not use the CONFIGURE_ARGS defined for the else block of WITH_GOST.

.if defined(WITH_GOST)
BUILD_DEPENDS+= openssl>=1.0:${PORTSDIR}/security/openssl
.else
CONFIGURE_ARGS+=        --disable-gost
.endif

If I manually edit the makefile and add '--disable-gost' to the post-configure block above, I can successfully build the port with EXAMPLES enabled and GOST disabled. I am not, however, sure how to include CONFIGURE_ARGS in the post-configure block appropriately (due to my inexperience with the ports makefile system).

Fix: 

Add CONFIGURE_ARGS to the post-configure block in the WITH_EXAMPLES section. The '--disable-gost' configuration argument is not being propagated to the nested configure invocation.
How-To-Repeat: cd /usr/ports/dns/ldns
make config
# enable EXAMPLES
# disable GOST
make
Comment 1 Edwin Groothuis freebsd_committer 2010-12-15 04:40:13 UTC
Maintainer of dns/ldns,

Please note that PR ports/153165 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/153165

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer 2010-12-15 04:40:15 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 dfilter service freebsd_committer 2010-12-20 21:41:36 UTC
ohauer      2010-12-20 21:41:30 UTC

  FreeBSD ports repository

  Modified files:
    dns/ldns             Makefile 
  Log:
   - change maintainer to submitter (NLnetNLabs)
   - patch includes fix for PR ports/153165
     port dns/ldns fails to build with config (EXAMPLES=on and GOST=off)
   - bump PORTREVISION
  
  PR:             ports/153228 ports/153165
  Submitted by:   Jaap Akkerhuis <jaap _at_ NLnetLabs.nl> (new maintainer)
  Approved by:    Konstantin Saurbier <konstantin _at_ saurbier.net> (old maintainer)
  
  Revision  Changes    Path
  1.21      +7 -4      ports/dns/ldns/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Olli Hauer freebsd_committer 2010-12-20 21:42:07 UTC
State Changed
From-To: feedback->closed

PR obsolated by PR ports/153228