Bug 153525 - [PATCH] databases/mongodb: Fix build for PREFIX != /usr/local and install header files
[PATCH] databases/mongodb: Fix build for PREFIX != /usr/local and install hea...
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: Renato Botelho
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-29 19:00 UTC by Renato Botelho
Modified: 2010-12-30 10:30 UTC (History)
1 user (show)

See Also:


Attachments
mongodb-1.6.5_1.patch (9.06 KB, patch)
2010-12-29 19:00 UTC, Renato Botelho
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Renato Botelho freebsd_committer 2010-12-29 19:00:22 UTC
Current version of this port has a bug, if you try to build it with PREFIX !=
/usr/local it doesn't build.

This is caused because of REINPLACE_CMD is replaceing all occourrences of
/usr/local by PREFIX and it breaks paths where it looks for libraries.

Since i was touching it, i've make some improvements:

- Get rid of manual installation and use scons to do it
- Add a new OPTION to install development part of it (lilbraries and header
  files). It's useful when you want to write software and link it against
  libmongoclient
- Add a REINPLACE_CMD to make scons strip binaries for freebsd (it should be
  sent as a patch to upstream)
- Use --prefix param instead of replace default prefix on SConstruct

Port maintainer (mail@derzinn.de) is cc'd.

Generated with FreeBSD Port Tools 0.99

How-To-Repeat: 
make PREFIX=/tmp
Comment 1 Edwin Groothuis freebsd_committer 2010-12-29 19:00:31 UTC
Responsible Changed
From-To: freebsd-ports-bugs->garga

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer 2010-12-29 19:00:34 UTC
Maintainer of databases/mongodb,

Please note that PR ports/153525 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/153525

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer 2010-12-29 19:00:37 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 mail 2010-12-29 22:13:09 UTC
i approve the patch. thanks.
Comment 5 dfilter freebsd_committer 2010-12-30 10:29:08 UTC
garga       2010-12-30 10:29:03 UTC

  FreeBSD ports repository

  Modified files:
    databases/mongodb    Makefile pkg-plist 
  Log:
  - Fix build when PREFIX != /usr/local
  - Instead of replace all /usr/local occourences on SConstruct file, use --prefix
  argument
  - Get rid of manual installation and use scons install instead
  - Strip binaries on FreeBSD as scons were doing for solaris end linux
  - Add a new OPTION (off by default) called DEVEL to install library and header
  files, it's useful when you need to link binaries against libmongoclient
  - Bump PORTREVISION since pkg-plist has changed
  
  PR:             ports/153525
  Submitted by:   garga@
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.18      +14 -10    ports/databases/mongodb/Makefile
  1.4       +173 -2    ports/databases/mongodb/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Renato Botelho freebsd_committer 2010-12-30 10:29:28 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!