Replace an if-less elif that causes some pre-processors to choke, including that of lang/gcc45.
Fix: Patch attached with submission follows:
Submitter has GNATS access (via the GNATS Auto Assign Tool)
Maintainer of sysutils/rename,
Please note that PR ports/154173 has just been submitted.
If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.
The full text of the PR can be found at:
Edwin Groothuis via the GNATS Auto Assign Tool
Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
I just took maintainership of this port at the author/maintainer's request. Will
check for regression with base gcc and nod on this tomorrow.
This is approved, but I would like to incorporate it into this commit.
I also tested this with clang, which spit out a warning about a non-string
literal not being secure, which I have also corrected.
On 2/7/11, b. f. <firstname.lastname@example.org> wrote:
> On 2/5/11, Joseph S. Atkinson <email@example.com> wrote:
>> The following reply was made to PR ports/154173; it has been noted by
>> From: "Joseph S. Atkinson" <jsa@FreeBSD.org>
>> To: bug-followup@FreeBSD.org, bf@FreeBSD.org
>> Subject: Re: ports/154173: [PATCH]sysutils/rename: fix compilation with
>> versions of gcc
>> Date: Sat, 05 Feb 2011 15:11:57 -0500
>> This is a multi-part message in MIME format.
>> Content-Type: text/plain; charset=ISO-8859-1; format=flowed
>> Content-Transfer-Encoding: 7bit
>> This is approved, but I would like to incorporate it into this commit.
>> I also tested this with clang, which spit out a warning about a
>> literal not being secure, which I have also corrected.
> Seems fine to me. There are a lot of grammar and spelling mistakes in
> the manpage, and "skipped" is wrongly written with one 'p' in some
> printf's. When you correct the problem mentioned in the PR, please
> close it.
Any movement on this? If you're too busy at the moment, I can commit
either your patch or mine, and close this PR.
jsa 2011-03-16 19:32:21 UTC
FreeBSD ports repository
Fix when building with GCC 4.5. While here, fix gripe with clang and a
Submitted by: bf
Approved by: kwm (mentor)
Revision Changes Path
1.5 +1 -0 ports/sysutils/rename/Makefile
1.1 +28 -0 ports/sysutils/rename/files/patch-rename.c (new)
firstname.lastname@example.org mailing list
To unsubscribe, send any mail to "email@example.com"