Fix the option to build profiling libraries as was done in ports/150549 and ports/150174 for math/lapack and math/blas, respectively. Remove the devel/binutils-related bits, because USE_BINUTILS is now set for all ports that USE_FORTRAN in bsd.gcc.mk.
Fix: Patch attached with submission follows:
Submitter has GNATS access (via the GNATS Auto Assign Tool)
Maintainer of math/levmar,
Please note that PR ports/154645 has just been submitted.
If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.
The full text of the PR can be found at:
Edwin Groothuis via the GNATS Auto Assign Tool
Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Dear Mr or Ms b.f.
Thank you very much for taking care of the problem.
I approve the PR, please commit your patch
after applying attached diff which fixes my typos in the port.
Thanks in advance,
> Dear Mr or Ms b.f.
Mr., but don't worry about that. :)
> Thank you very much for taking care of the problem.
> I approve the PR, please commit your patch
> after applying attached diff which fixes my typos in the port.
Thanks. But I'm not that some of these are typos: -pthread is the
common alias for the threading linkage on FreeBSD. See the compiler
How about the attached patch instead? ( I added a test target for
convenience, and major versions of required libraries for safety. I
added PTHREAD_LIBS to the linking flags in all cases, because lapack
3.3.0 is now thread-safe.)
Dear Mr. b.f.,
I agree with your proposals:
* to add test target for convenience;
* to add PTHREAD_CFLAGS and PTHREAD_LIB to cflags and linking flags
I approve the PR again.
Thank you for useful suggestions to the port.
bf 2011-02-22 17:40:44 UTC
FreeBSD ports repository
- Fix the option to build profiling libraries as was done in
ports/150174 and ports/150549 for math/blas and math/lapack,
- Remove the devel/binutils-related additions to MAKE_ENV,
as these are now done by default.
- Adjust linking
- Add a test target
- Bump PORTREVISION
Approved by: makc, miwi (mentors, implicit)
Eijiro Shibusawa (maintainer)
Revision Changes Path
1.3 +31 -16 ports/math/levmar/Makefile
firstname.lastname@example.org mailing list
To unsubscribe, send any mail to "email@example.com"