Bug 154770 - [patch][regression] Mk/bsd.port.mk: do-fetch fails on ftp:// transfers with ftp(1) fallback
Summary: [patch][regression] Mk/bsd.port.mk: do-fetch fails on ftp:// transfers with f...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-14 08:10 UTC by swell.k
Modified: 2015-06-12 23:29 UTC (History)
0 users

See Also:


Attachments
a.diff (509 bytes, patch)
2011-02-14 08:10 UTC, swell.k
no flags Details | Diff
file.diff (688 bytes, patch)
2011-02-14 08:10 UTC, swell.k
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description swell.k 2011-02-14 08:10:05 UTC
When restarting ftp:// transfer ftp(1)'s reget wants local file to exists.
This doesn't affect http:// and file:// transfers.

Introduced by `-R' option from ports/109966.

Fix: Don't restart any proto transfer as reget is disabled by default in
bsd.port.mk, anyway.

Alternatively, one can make reget to get the file if it doesn't exist
similar to other protos.
How-To-Repeat: $ sudo mv /usr/bin/fetch /tmp
$ cd devel/gettext
$ make checksum DISTDIR=/tmp MASTER_SITES= MASTER_SITE_OVERRIDE=
===>  License check disabled, port has not defined LICENSE
=> gettext-0.18.1.1.tar.gz doesn't seem to exist in /tmp/.
=> Attempting to fetch ftp://ftp.FreeBSD.org/pub/FreeBSD/ports/distfiles//gettext-0.18.1.1.tar.gz
Trying 204.152.184.73...
Connected to ftp.FreeBSD.org.
220 Welcome to freebsd.isc.org.
331 Please specify the password.
230 Login successful.
Remote system type is UNIX.
Using binary mode to transfer files.
200 Switching to Binary mode.
250 Directory successfully changed.
250-If you're looking for one of the FreeBSD releases, please look in the
250-releases/${ARCH}/${RELNAME} directory, where ARCH = "alpha", "amd64",
250-"i386", "ia64", "pc98", or "sparc64" and RELNAME = the release
250-you're interested in, e.g. "7.1-RELEASE" or "8.0-RELEASE".
250 Directory successfully changed.
250 Directory successfully changed.
250 Directory successfully changed.
ftp: local: gettext-0.18.1.1.tar.gz: No such file or directory
221 Goodbye.
cannot open gettext-0.18.1.1.tar.gz: No such file or directory
*** Error code 2

Stop in /usr/ports/devel/gettext.

$ touch /tmp/gettext-0.18.1.1.tar.gz
$ make checksum FETCH_REGET=1 DISTDIR=/tmp MASTER_SITES= MASTER_SITE_OVERRIDE=
===>  License check disabled, port has not defined LICENSE
=> SHA256 Checksum mismatch for gettext-0.18.1.1.tar.gz.
===>  Refetch for 1 more times files: gettext-0.18.1.1.tar.gz
===>  License check disabled, port has not defined LICENSE
=> gettext-0.18.1.1.tar.gz doesn't seem to exist in /tmp/.
=> Attempting to fetch ftp://ftp.FreeBSD.org/pub/FreeBSD/ports/distfiles//gettext-0.18.1.1.tar.gz
Trying 204.152.184.73...
Connected to ftp.FreeBSD.org.
220 Welcome to freebsd.isc.org.
331 Please specify the password.
230 Login successful.
Remote system type is UNIX.
Using binary mode to transfer files.
200 Switching to Binary mode.
250 Directory successfully changed.
250-If you're looking for one of the FreeBSD releases, please look in the
250-releases/${ARCH}/${RELNAME} directory, where ARCH = "alpha", "amd64",
250-"i386", "ia64", "pc98", or "sparc64" and RELNAME = the release
250-you're interested in, e.g. "7.1-RELEASE" or "8.0-RELEASE".
250 Directory successfully changed.
250 Directory successfully changed.
250 Directory successfully changed.
local: gettext-0.18.1.1.tar.gz remote: gettext-0.18.1.1.tar.gz
229 Entering Extended Passive Mode (|||13757|).
150 Opening BINARY mode data connection for gettext-0.18.1.1.tar.gz (15139737 bytes).
100% |************************************| 14784 KB  106.64 KB/s    00:00 ETA
226 File send OK.
15139737 bytes received in 02:18 (106.48 KB/s)
221 Goodbye.
===>  License check disabled, port has not defined LICENSE
=> SHA256 Checksum OK for gettext-0.18.1.1.tar.gz.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-02-14 08:10:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

bsd.port.mk is portmgr territory (via the GNATS Auto Assign Tool)
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2014-06-02 03:03:41 UTC
Infrastructure PR.
Comment 3 Mathieu Arnold freebsd_committer freebsd_triage 2015-06-12 23:29:05 UTC
I think this was fixed in fetch a while back.