Bug 155104 - [zfs][patch] use /dev prefix by default when importing
Summary: [zfs][patch] use /dev prefix by default when importing
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 9.0-CURRENT
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-27 23:00 UTC by swell.k
Modified: 2019-01-19 20:04 UTC (History)
1 user (show)

See Also:

Attachments
a.diff (634 bytes, patch)
2011-02-27 23:00 UTC, swell.k 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description swell.k 2011-02-27 23:00:24 UTC 
Don't use Solaris prefix /dev/dsk when trying
zpool_{find,search}_import() without arguments.

cf. http://docs.freebsd.org/cgi/mid.cgi?86lj1s3pv0.fsf

How-To-Repeat: $ zdb -e tank
Comment 1 dfilter service freebsd_committer freebsd_triage 2012-05-15 18:11:15 UTC 
Author: avg
Date: Tue May 15 17:11:00 2012
New Revision: 235479
URL: http://svn.freebsd.org/changeset/base/235479

Log:
  zpool_find_import_impl: another /dev/dsk -> /dev fix
  
  This seems to fix zdb -e behavior.
  
  PR:		bin/155104
  Submitted by:	swell.k@gmail.com
  MFC after:	2 weeks

Modified:
  head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c

Modified: head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c
==============================================================================
--- head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c	Tue May 15 17:07:29 2012	(r235478)
+++ head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c	Tue May 15 17:11:00 2012	(r235479)
@@ -1145,7 +1145,7 @@ zpool_find_import_impl(libzfs_handle_t *
 	char *end, **dir = iarg->path;
 	size_t pathleft;
 	nvlist_t *ret = NULL;
-	static char *default_dir = "/dev/dsk";
+	static char *default_dir = "/dev";
 	pool_list_t pools = { 0 };
 	pool_entry_t *pe, *penext;
 	vdev_entry_t *ve, *venext;
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-06-02 19:57:01 UTC 
Author: avg
Date: Sat Jun  2 18:56:41 2012
New Revision: 236467
URL: http://svn.freebsd.org/changeset/base/236467

Log:
  MFC r235479: zpool_find_import_impl: another /dev/dsk -> /dev fix
  
  PR:		bin/155104

Modified:
  stable/9/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c
Directory Properties:
  stable/9/cddl/contrib/opensolaris/   (props changed)

Modified: stable/9/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c
==============================================================================
--- stable/9/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c	Sat Jun  2 18:55:25 2012	(r236466)
+++ stable/9/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c	Sat Jun  2 18:56:41 2012	(r236467)
@@ -1145,7 +1145,7 @@ zpool_find_import_impl(libzfs_handle_t *
 	char *end, **dir = iarg->path;
 	size_t pathleft;
 	nvlist_t *ret = NULL;
-	static char *default_dir = "/dev/dsk";
+	static char *default_dir = "/dev";
 	pool_list_t pools = { 0 };
 	pool_entry_t *pe, *penext;
 	vdev_entry_t *ve, *venext;
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 3 dfilter service freebsd_committer freebsd_triage 2012-06-02 20:02:07 UTC 
Author: avg
Date: Sat Jun  2 19:01:47 2012
New Revision: 236471
URL: http://svn.freebsd.org/changeset/base/236471

Log:
  MFC r235479: zpool_find_import_impl: another /dev//dsk -> /dev fix
  
  PR:		bin/155104

Modified:
  stable/8/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c
Directory Properties:
  stable/8/cddl/contrib/opensolaris/   (props changed)

Modified: stable/8/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c
==============================================================================
--- stable/8/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c	Sat Jun  2 18:59:18 2012	(r236470)
+++ stable/8/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c	Sat Jun  2 19:01:47 2012	(r236471)
@@ -1145,7 +1145,7 @@ zpool_find_import_impl(libzfs_handle_t *
 	char *end, **dir = iarg->path;
 	size_t pathleft;
 	nvlist_t *ret = NULL;
-	static char *default_dir = "/dev/dsk";
+	static char *default_dir = "/dev";
 	pool_list_t pools = { 0 };
 	pool_entry_t *pe, *penext;
 	vdev_entry_t *ve, *venext;
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 4 vsjcfm 2014-01-19 10:45:17 UTC 
Why this PR is still open even when the commit was made a long time ago?
Comment 5 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 08:01:37 UTC 
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 6 Oleksandr Tymoshenko freebsd_committer freebsd_triage 2019-01-19 20:04:16 UTC 
There was a commit referencing this bug, but it's still not closed and has been inactive for some time. Closing as "fixed". Please re-open it if the issue hasn't been completely resolved.