Bug 155168 - [MAINTAINER] Fix port: audio/musicpd: Incorporate upstream fix for 24-bit
Summary: [MAINTAINER] Fix port: audio/musicpd: Incorporate upstream fix for 24-bit
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Wesley Shields
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-01 18:40 UTC by Chris Rees
Modified: 2011-03-01 19:50 UTC (History)
0 users

See Also:

Attachments
musicpd-fix-24-bit.diff (1.07 KB, patch)
2011-03-01 18:40 UTC, Chris Rees 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rees 2011-03-01 18:40:09 UTC 
	I've had many complaints about musicpd giving white noise since the update; since talking with upstream a temporary workaround has been added [1].
	[1] http://git.musicpd.org/cgit/master/mpd.git/commit/?h=v0.16.x&id=a1d1c2beaa54f76bbf92b2a5fd83c4a582a0316b

Fix: - Disable 24-bit audio (upstream fix)
	- While here, silence a REINPLACE

	Submitted by: Chris Rees (utisoft_at_gmail.com) (maintainer)

Disclaimer: I know it's a nasty sed-by-address, but it's only until the next version bump, so I didn't think it's worth making a patchfile.

If you want to see the results, I've diffed src/output/oss_plugin.c against the .bak before the sed [2].

[2] http://www.bayofrum.net/~chris/patches/musicpd-src-output-oss-plugin-c.diff
Comment 1 Wesley Shields freebsd_committer freebsd_triage 2011-03-01 19:41:20 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->wxs

I'll take it.
Comment 2 Wesley Shields freebsd_committer freebsd_triage 2011-03-01 19:49:45 UTC 
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2011-03-01 19:49:45 UTC 
wxs         2011-03-01 19:49:36 UTC

  FreeBSD ports repository

  Modified files:
    audio/musicpd        Makefile 
  Log:
  Include upstream fix for 24-bit audio (disable it).
  Silence a REINPLACE_CMD while we are here.
  
  PR:             ports/155168
  Submitted by:   Chris Rees <utisoft@gmail.com> (maintainer)
  
  Revision  Changes    Path
  1.61      +6 -2      ports/audio/musicpd/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"