Bug 155201 - [PATCH]bsd.port.mk: fix portion of CONFIGURE_ENV added WITH_BINUTILS
Summary: [PATCH]bsd.port.mk: fix portion of CONFIGURE_ENV added WITH_BINUTILS
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-02 16:40 UTC by Brendan Fabeny
Modified: 2019-09-04 13:39 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (839 bytes, patch)
2011-03-02 16:40 UTC, Brendan Fabeny
no flags Details | Diff
PR155201_3.diff (2.44 KB, patch)
2011-07-23 10:33 UTC, b. f.
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Fabeny freebsd_committer 2011-03-02 16:40:11 UTC
Various tools from devel/binutils are supposed to be added to the
CONFIGURE_ENV when WITH_BINUTILS is defined.  However, when a port
relies on bsd.autotools.mk, bsd.php.mk, or bsd.xorg.mk to define
GNU_CONFIGURE instead of declaring this variable explicitly in the
port Makefile, these tools may not be added.

Fix: To fix this, change the way that USE_BINUTILS modifies CONFIGURE_ENV:
like other knobs, make additions regardless of whether GNU_CONFIGURE
is defined, subject only to a new optional blacklist variable
BINUTILS_NO_CONFIGURE_ENV, which is analogous to the existing
BINUTILS_NO_MAKE_ENV. This eliminates the as-yet-unused variable
BINUTILS_CONFIGURE, and also adds the tools to the CONFIGURE_ENV for
ports that use HAS_CONFIGURE.

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer 2011-03-02 16:40:26 UTC
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

bsd.port.mk is portmgr territory (via the GNATS Auto Assign Tool)
Comment 2 b. f. 2011-07-23 10:33:02 UTC
I've attached a revised version of the patch, to account for the
addition of the elfedit utility in the most recent version of
devel/binutils, and the strip(1)-related problems uncovered by Mark in
his sparc64 builds.  It turns out that the proper version of strip(1)
also needs to be used, both explicitly and via the "-s" flag of
install(1), or some builds will fail. For the former, the common
autotools variable STRIP should be set to be STRIP_CMD in
CONFIGURE_ENV, and for the latter, STRIPBIN  should be set to be
STRIP_CMD in both CONFIGURE_ENV and MAKE_ENV.  A few ports that use
STRIP in a non-standard way may need to be patched.

b.
Comment 3 b. f. 2012-02-21 18:27:05 UTC
On 7/23/11, b. f. <bf1783@googlemail.com> wrote:
> I've attached a revised version of the patch, to account for the
> addition of the elfedit utility in the most recent version of
> devel/binutils, and the strip(1)-related problems uncovered by Mark in
> his sparc64 builds.  It turns out that the proper version of strip(1)
> also needs to be used, both explicitly and via the "-s" flag of
> install(1), or some builds will fail. For the former, the common
> autotools variable STRIP should be set to be STRIP_CMD in
> CONFIGURE_ENV, and for the latter, STRIPBIN  should be set to be
> STRIP_CMD in both CONFIGURE_ENV and MAKE_ENV.  A few ports that use
> STRIP in a non-standard way may need to be patched.

I have been working on ports/160492, which is complicated by the
absence of the patch in ports/155201.  Could portmgr arrange to test
the patch in ports/155201, so that we can try to solve some of the
build problems for USE_GCC?

Regards,
          b.
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2014-06-02 03:03:20 UTC
Infrastructure PR.
Comment 5 Mathieu Arnold freebsd_committer 2015-06-12 23:37:58 UTC
I can't get if this is still needed, wondering what tijl@ thinks about it.