Bug 155974 - [patch] dns/noip: Fix detection of network devices
Summary: [patch] dns/noip: Fix detection of network devices
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-27 19:10 UTC by David Naylor
Modified: 2011-03-28 18:01 UTC (History)
0 users

See Also:


Attachments
file.diff (557 bytes, patch)
2011-03-27 19:10 UTC, David Naylor
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Naylor 2011-03-27 19:10:08 UTC
noip2 fails to detect the network devices, displaying what appears to be a broken list.

The root cause of this is the failed attempt to define bsd_with_getifaddrs as the variable ARCH is used for that purpose and get overridden by ports with the current architecture.  

The attached patch fixes that and also passes ${CFLAGS} to `cc`.  The patch replaces files/patch-Makefile

Fix: Pass -Dbsd_with_getifaddrs explicitly to `cc`.  

Patch attached with submission follows:
How-To-Repeat: Do:
# cd /usr/ports/dns/noip
# make install conf

Observe the broken list of network devices
Comment 1 Edwin Groothuis freebsd_committer 2011-03-27 19:10:18 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ehaupt

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2011-03-28 17:55:00 UTC
ehaupt      2011-03-28 16:54:46 UTC

  FreeBSD ports repository

  Modified files:
    .                    GIDs UIDs 
    dns/noip             Makefile pkg-plist 
    dns/noip/files       patch-Makefile 
  Removed files:
    dns/noip             pkg-deinstall pkg-install 
  Log:
  - Pass -Dbsd_with_getifaddrs to CFLAGS in order to get a correct network
    interface list [1]
  
  PR:             155974 [1]
  Submitted by:   David Naylor <naylor.b.david@gmail.com> [1]
  
  Revision  Changes    Path
  1.129     +2 -1      ports/GIDs
  1.143     +2 -1      ports/UIDs
  1.20      +7 -3      ports/dns/noip/Makefile
  1.6       +3 -3      ports/dns/noip/files/patch-Makefile
  1.3       +0 -20     ports/dns/noip/pkg-deinstall (dead)
  1.3       +0 -32     ports/dns/noip/pkg-install (dead)
  1.5       +1 -0      ports/dns/noip/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Emanuel Haupt freebsd_committer 2011-03-28 18:01:29 UTC
State Changed
From-To: open->closed

Committed, thanks!