Bug 156164 - [PATCH] ports-mgmt/portlint: modify regex that correlates WITH(OUT)_FOO with OPTIONS
Summary: [PATCH] ports-mgmt/portlint: modify regex that correlates WITH(OUT)_FOO with ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Joe Marcus Clarke
Depends on:
Reported: 2011-04-04 00:30 UTC by Sahil Tandon
Modified: 2011-06-26 22:40 UTC (History)
1 user (show)

See Also:

portlint.diff (713 bytes, patch)
2011-04-04 00:30 UTC, Sahil Tandon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sahil Tandon freebsd_committer 2011-04-04 00:30:12 UTC
I ran into a problem while working on mail/postfix, whose Makefile

 .if defined(WITH_DOVECOT) || defined(WITH_DOVECOT2)

Nevertheless, portlint(1) complains:

 WARN: Makefile: DOVECOT2 is listed in OPTIONS, but neither WITH_DOVECOT2 nor WITHOUT_DOVECOT2 appears.

The attached patch slightly modifies the regular expression used
to check whether OPTIONS appear in WITH(OUT)_FOO. I hope this is
not something that causes breakage in other sections of the script;
but if it does, we still need another regex that gracefully handles
multiple instances of WITH(OUT)_FOO on a single line. Someone with
superior perl-fu will probably laugh heartily at my change and then
improve it considerably. :-)  Thanks for taking a look.
Comment 1 Edwin Groothuis freebsd_committer 2011-04-04 00:30:23 UTC
Responsible Changed
From-To: freebsd-ports-bugs->marcus

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Joe Marcus Clarke freebsd_committer 2011-04-04 00:49:04 UTC
State Changed
From-To: open->patched

Committed to my CVS repo pending the next release.  Thanks!
Comment 3 Joe Marcus Clarke freebsd_committer 2011-06-26 22:32:02 UTC
State Changed
From-To: patched->closed

Committed, thanks!
Comment 4 dfilter service freebsd_committer 2011-06-26 22:32:08 UTC
marcus      2011-06-26 21:31:55 UTC

  FreeBSD ports repository

  Modified files:
    ports-mgmt/portlint  Makefile 
    ports-mgmt/portlint/src portlint.pl 
  Removed files:
    ports-mgmt/portlint  pkg-plist 
  Update to 2.13.6.
  * Be more careful is searching for WITH(OUT)_FOO OPTIONS checks so to avoid
  false positive warnings. [1]
  * Support := in the *_DEPENDS section. [2]
  * Make sure we expand DISTNAME to catch potential superfluous uses of it. [3]
  * Fix the error seen when one passes CPPFLAGS to CONFIGURE_ENV. [4]
  * Add the license block check after the MAINTAINER block [5]
  * Add a check for use of ${FIND}...${XARGS} ${RM}. [6]
  PR:             156164 [1]
                  155753 [2]
                  154320 [3]
                  158305 [5]
                  157566 [6]
  Submitted by:   sahil [1]
                  "Ilya A. Arkhipov" <micro@heavennet.ru> [5]
  Reported by:    pav [4]
  Revision  Changes    Path
  1.145     +7 -2      ports/ports-mgmt/portlint/Makefile
  1.7       +0 -3      ports/ports-mgmt/portlint/pkg-plist (dead)
  1.122     +67 -26    ports/ports-mgmt/portlint/src/portlint.pl
cvs-all@freebsd.org mailing list
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"