Bug 156367 - net/pecl-yaz still BROKEN
Summary: net/pecl-yaz still BROKEN
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-13 11:50 UTC by Frank Wall
Modified: 2011-06-25 08:20 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Wall 2011-04-13 11:50:05 UTC
Unfortunately net/pecl-yaz cannot be build after upgrading net/yaz to version 4.1.7. The configure script fails. I tried both i386 and amd64 on FreeBSD 7.3. I'm using PHP 5.2, but I don't know if it matters or not.

How-To-Repeat: 1. install yaz-4.1.7 (net/yaz)
2. make -C /usr/ports/net/pecl-yaz fails:

===>  Configuring for pecl-yaz-1.0.14_3
[...]
checking for PHP extension directory... /usr/local/lib/php/20060613
[...]
checking for YAZ support... yes, shared
checking for YAZ version... configure: error: YAZ version 3.0.2 or later required.
===>  Script "configure" failed unexpectedly.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-04-13 11:50:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

miwi@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-04-13 11:50:16 UTC
Maintainer of net/pecl-yaz,

Please note that PR ports/156367 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/156367

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2011-04-13 11:50:18 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Frank Wall 2011-04-13 14:40:09 UTC
Well, I think the pre-configure section in the Makefile
is the reason for this problem. The REINPLACE_CMD seems
to be wrong.

I tried to figure out what happens and did a little 
tracing on the configure script:

/usr/ports/net/pecl-yaz/work/yaz-1.0.14# sh -x configure 2>&1 |grep YAZ
 
+ printf %s\n configure:4054: checking for YAZ support
+ printf %s checking for YAZ support... 
checking for YAZ support... + test  = set
+ PHP_YAZ=no
+ PHP_YAZ=yes
+ printf %s\n #define HAVE_YAZ 1
+ ICU_CPPFLAGS= -I/usr/local/include  -D YAZ_HAVE_ICU=1
+ YAZVERSION=4.1.7
+ YAZLIB=-lyaz
[..]

As you can see, the version information is written to
the YAZVERSION variable, but the REINPLACE_CMD modifies
the configure script to use the YAZ_VERSION variable.

So I suggest to NOT use the REINPLACE_CMD for yaz 4.1.7
and newer. I remember this was introduced with ports/154527 [1].
So this all seems somewhat odd to me.

This patch fixes it for me.

--- net/pecl-yaz/Makefile.orig	2011-03-23 17:45:30.000000000 +0100
+++ net/pecl-yaz/Makefile	2011-04-13 15:34:50.000000000 +0200
@@ -27,7 +27,7 @@
 .include <bsd.port.pre.mk>
 
 pre-configure:
-	@if [ `${PKG_INFO} 'yaz>=4.1.4' > /dev/null 2>&1` ]; then \
+	@if ${PKG_INFO} 'yaz<=4.1.6' > /dev/null 2>&1; then \
 		${REINPLACE_CMD} -e 's|YAZVERSION|YAZ_VERSION|g' \
 				${WRKSRC}/configure; fi


By using this patch configure is happy again:

===>  Configuring for pecl-yaz-1.0.14_3
[...]
checking for PHP extension directory... /usr/local/lib/php/20060613
[...]
checking for YAZ support... yes, shared
checking for YAZ version... 4.1.7
[...]

[1] http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/154527

Bye
- Frank
Comment 5 Frank Wall 2011-04-13 14:40:09 UTC
Well, I think the pre-configure section in the Makefile
is the reason for this problem. The REINPLACE_CMD seems
to be wrong.

I tried to figure out what happens and did a little 
tracing on the configure script:

/usr/ports/net/pecl-yaz/work/yaz-1.0.14# sh -x configure 2>&1 |grep YAZ
 
+ printf %s\n configure:4054: checking for YAZ support
+ printf %s checking for YAZ support... 
checking for YAZ support... + test  = set
+ PHP_YAZ=no
+ PHP_YAZ=yes
+ printf %s\n #define HAVE_YAZ 1
+ ICU_CPPFLAGS= -I/usr/local/include  -D YAZ_HAVE_ICU=1
+ YAZVERSION=4.1.7
+ YAZLIB=-lyaz
[..]

As you can see, the version information is written to
the YAZVERSION variable, but the REINPLACE_CMD modifies
the configure script to use the YAZ_VERSION variable.

So I suggest to NOT use the REINPLACE_CMD for yaz 4.1.7
and newer. I remember this was introduced with ports/154527 [1].
So this all seems somewhat odd to me.

This patch fixes it for me.

--- net/pecl-yaz/Makefile.orig	2011-03-23 17:45:30.000000000 +0100
+++ net/pecl-yaz/Makefile	2011-04-13 15:34:50.000000000 +0200
@@ -27,7 +27,7 @@
 .include <bsd.port.pre.mk>
 
 pre-configure:
-	@if [ `${PKG_INFO} 'yaz>=4.1.4' > /dev/null 2>&1` ]; then \
+	@if ${PKG_INFO} 'yaz<=4.1.6' > /dev/null 2>&1; then \
 		${REINPLACE_CMD} -e 's|YAZVERSION|YAZ_VERSION|g' \
 				${WRKSRC}/configure; fi


By using this patch configure is happy again:

===>  Configuring for pecl-yaz-1.0.14_3
[...]
checking for PHP extension directory... /usr/local/lib/php/20060613
[...]
checking for YAZ support... yes, shared
checking for YAZ version... 4.1.7
[...]

[1] http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/154527

Bye
- Frank
Comment 6 Martin Wilke freebsd_committer freebsd_triage 2011-06-25 08:11:45 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 7 dfilter service freebsd_committer freebsd_triage 2011-06-25 08:12:10 UTC
miwi        2011-06-25 07:11:34 UTC

  FreeBSD ports repository

  Modified files:
    net/pecl-yaz         Makefile 
  Log:
  - Fix build with net/yaz
  
  PR:             156367
  Approved by:    maintainer timeout
  
  Revision  Changes    Path
  1.14      +2 -2      ports/net/pecl-yaz/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"