Bug 156373 - [patch] devel/svn2git: update from 1.0.3 to 1.0.4
Summary: [patch] devel/svn2git: update from 1.0.3 to 1.0.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Frederic Culot
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-13 18:00 UTC by David Naylor
Modified: 2011-04-13 20:40 UTC (History)
0 users

See Also:


Attachments
file.diff (915 bytes, patch)
2011-04-13 18:00 UTC, David Naylor
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Naylor 2011-04-13 18:00:25 UTC
commit 9677b1fea3ab82db3e9185439938d9e2380e02d4
Author: Sebastian Pipping <sebastian@pipping.org>
Date:   Fri Apr 8 07:16:44 2011 +0200

    Save deleted branches in a visible namespace
    
     - The branch is first created properly and then deleted
       (line "progress SVN r77 branch config-header = :0 # delete")
    
     - Jehan's post-1.0.3 commit 584005f2e26149282aa12c4a0367d250caaf3918
       writes a backup of the branches latest ref to refs/backup/
       on deletion.  Many thanks for that commit!
    
    However, in my opinion the problem with the current code is that it
    makes it much too easy to lose history during the conversion to Git.
    Without a tag or branch pointing to it the commits will fall off easily,
    especially if people use "git clone" on the bare Git repository created
    by svn2git.
    
    It would be safer and useful to create visible tags for this, e.g.
    refs/tags/branch-bugfix17-deleted.
    
    My attached patch changes Jehan's code to do just that.
    Please consider application - this patch really matters to me.
    If you'd rather have both a ref in refs/backup/ and in refs/tags/ or
    require a command line option for it I can adjust the patch for you.
    
    Thanks for listening,

commit 584005f2e26149282aa12c4a0367d250caaf3918
Author: Jehan Bing <nahor.j@gmail.com>
Date:   Thu Mar 10 10:54:52 2011 -0800

    Create backup reference before deletion of the original branch
    
    Ensure that the backup reference is created before deleting the original
    branch. As it was, the deletion was executed earlier causing the backup
    reference to point to a non-existing branch so was not created.

commit 34f881571e48b6fb71f687944ff4420d589a6d22
Author: Nicol<C3><A1>s Alvarez <nicolas.alvarez@gmail.com>
Date:   Wed Mar 16 17:37:22 2011 -0300

    Remove unnecessary const casts.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer 2011-04-13 18:00:37 UTC
Class Changed
From-To: sw-bug->maintainer-update

Fix category (submitter is maintainer) (via the GNATS Auto Assign Tool)
Comment 2 Frederic Culot freebsd_committer 2011-04-13 18:58:35 UTC
Responsible Changed
From-To: freebsd-ports-bugs->culot

I'll take it.
Comment 3 dfilter service freebsd_committer 2011-04-13 20:38:42 UTC
culot       2011-04-13 19:38:28 UTC

  FreeBSD ports repository

  Modified files:
    devel/svn2git        Makefile distinfo 
  Log:
  - Update to 1.0.4
  
  PR:             ports/156373
  Submitted by:   David Naylor <naylor.b.david AT gmail.com> (maintainer)
  
  Revision  Changes    Path
  1.2       +1 -1      ports/devel/svn2git/Makefile
  1.2       +2 -2      ports/devel/svn2git/distinfo
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Frederic Culot freebsd_committer 2011-04-13 20:38:55 UTC
State Changed
From-To: open->closed

Committed. Thanks!