Bug 156419 - [update] dns/ldns - add an option to install python bindings
Summary: [update] dns/ldns - add an option to install python bindings
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-15 14:20 UTC by Emanuel Haupt
Modified: 2011-04-16 21:50 UTC (History)
0 users

See Also:


Attachments
ldns.patch (1.90 KB, patch)
2011-04-15 14:20 UTC, Emanuel Haupt
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emanuel Haupt freebsd_committer 2011-04-15 14:20:05 UTC
I need the python bindings for updating one of my ports. The following
tinderbox-tested patch provides an OPTIONS flag to install the python bindings
for dns/ldns.

Also add an additional distfile mirror.
Comment 1 Edwin Groothuis freebsd_committer 2011-04-15 14:20:15 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ehaupt

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer 2011-04-15 14:20:18 UTC
Maintainer of dns/ldns,

Please note that PR ports/156419 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/156419

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer 2011-04-15 14:20:20 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Jaap Akkerhuis 2011-04-16 19:20:28 UTC
Edwin,

    Maintainer of dns/ldns,
    
    Please note that PR ports/156419 has just been submitted.

Noted. Why do these things always happen on my vacation :-)? I have more
time to deal with that in a couple of days if you want to wait on that.
    
    If it contains a patch for an upgrade, an enhancement or a bug fix
    you agree on, reply to this email stating that you approve the patch
    and a committer will take care of it.

It seems fine in principle. However:
    
    The full text of the PR can be found at:
        http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/156419

The PR description says:

	> I need the python bindings for updating one of my ports. The following
	> tinderbox-tested patch provides an OPTIONS flag to install the python
	> bindings for dns/ldns.

Note that the patch doesn't work on the non-supported 6.4 and older so it
should probably have an dependency on OSVERSION as well as in

	.if defined(WITH_PYLDNS) && ${OSVERSION} > 700000

Also, the PORTREVISION needs to be raised.

	> Also add an additional distfile mirror.

We are working on that.  I'm waiting for the mirror to come up.

	jaap
Comment 5 Emanuel Haupt freebsd_committer 2011-04-16 21:32:33 UTC
State Changed
From-To: feedback->open

Feedback received.
Comment 6 Emanuel Haupt freebsd_committer 2011-04-16 21:36:09 UTC
State Changed
From-To: open->closed

A PORTREVISION bump is not necessary since the new option is not affecing 
default option configuration (default off). There is no need to add additional 
makefile glue for non supported OSVERSIONS. 

Patch committed.
Comment 7 dfilter service freebsd_committer 2011-04-16 21:36:15 UTC
ehaupt      2011-04-16 20:36:06 UTC

  FreeBSD ports repository

  Modified files:
    dns/ldns             Makefile pkg-plist 
  Log:
  Add an option for installing python bindings.
  
  PR:             156419
  Approved by:    Jaap Akkerhuis <jaap@NLnetLabs.nl> (maintainer)
  
  Revision  Changes    Path
  1.24      +15 -2     ports/dns/ldns/Makefile
  1.10      +6 -0      ports/dns/ldns/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"