Bug 156734 - Fix port: sysutils/uhidd rc script fails to set default
Summary: Fix port: sysutils/uhidd rc script fails to set default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-30 14:30 UTC by Chris Rees
Modified: 2011-05-03 16:30 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rees 2011-04-30 14:30:09 UTC
If uhidd is installed and there is no uhidd_enable line in rc.conf there are complaints in /var/log/messages:

zeus root: /usr/local/etc/rc.d/uhidd: WARNING: $uhidd_enable is not set properly - see rc.conf(5).

Fix: 

- Set default value for uhidd_enabled in rc script

Submitted by: Chris Rees (utisoft@gmail.com)



http://www.bayofrum.net/~crees/patches/uhidd-rc-default.diff
How-To-Repeat: Install sysutils/uhidd-0.2.0 and run the rc script with no uhidd_enable line in rc.conf.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-04-30 14:30:20 UTC
Maintainer of sysutils/uhidd,

Please note that PR ports/156734 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/156734

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-04-30 14:30:23 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 kaiwang27 2011-05-01 07:06:43 UTC
Patch looks good to me. Thanks

Kai
Comment 4 kaiwang27 2011-05-01 09:47:12 UTC
Approved.

Kai
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2011-05-01 13:44:04 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 6 Greg Larkin freebsd_committer freebsd_triage 2011-05-03 16:20:13 UTC
State Changed
From-To: open->closed

Committed, thank you!
Comment 7 dfilter service freebsd_committer freebsd_triage 2011-05-03 16:20:17 UTC
glarkin     2011-05-03 15:20:02 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/uhidd       Makefile 
    sysutils/uhidd/files uhidd.in 
  Log:
  - Added rc.d default value
  - Bumped PORTREVISION
  
  PR:             ports/156734
  Submitted by:   Chris Rees <utisoft@gmail.com>
  Approved by:    Kai Wang <kaiwang27@gmail.com> (maintainer)
  
  Revision  Changes    Path
  1.5       +1 -0      ports/sysutils/uhidd/Makefile
  1.3       +3 -1      ports/sysutils/uhidd/files/uhidd.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"