The bare __aligned attribute no longer exists in new gcc (like gcc46 on my system). The following patch replaces it with the standard __attribute__.
Responsible Changed From-To: freebsd-ports-bugs->stas Over to maintainer (via the GNATS Auto Assign Tool)
Responsible Changed From-To: stas->freebsd-ports-bugs - back to the heap
Responsible Changed From-To: freebsd-ports-bugs->scheidell ill take a look at it
State Changed From-To: open->feedback i just tried this on valgrind 3.6.1_2,1, and FreeBSD 7.4, 8.2 and 9.0RC2 and it compiled just fine. (they seem to have older gcc installed by default) Could you clarify? did you install gcc46 from ports? could you come up with a patch/.ifdef/ test for newer version so that this does not interfeer with stock/standard included gcc? or, are you thinking that this patch will be upward compatible with older gcc?
No, it still does not build. In file included from ../include/vki/vki-freebsd.h:203:0, from ../include/pub_tool_vki.h:51, from mc_leakcheck.c:32: ../include/vki/vki-x86-freebsd.h:148:30: error: expected ':', ',', ';', '}' or '__attribute__' before '__aligned' ../include/vki/vki-x86-freebsd.h:218:30: error: expected ':', ',', ';', '}' or '__attribute__' before '__aligned' gmake[3]: *** [memcheck_x86_freebsd-mc_leakcheck.o] Error 1 At least, the new attribute is supported >= gcc-4.2, which is the stock compiler. -- Zhihao Yuan, nickname lichray The best way to predict the future is to invent it. ___________________________________________________ 4BSD -- http://4bsd.biz/
State Changed From-To: feedback->closed Committed, thanks
scheidell 2011-12-03 19:27:22 UTC FreeBSD ports repository Modified files: devel/valgrind Makefile Added files: devel/valgrind/files patch-include_vki_vki-x86-freebsd.h Log: -The base __aligned attribute no longer exists in gcc46+ -patch uses __attribute__ which is upward compatible with gcc42+ PR: ports/156881 Submitted by: Zhihao Yuan <lichray@gmail.com> Approved by: maintainer(timeout), gaboe(mentor) Feature safe: yes Revision Changes Path 1.52 +2 -6 ports/devel/valgrind/Makefile 1.1 +20 -0 ports/devel/valgrind/files/patch-include_vki_vki-x86-freebsd.h (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"