Mailscanner's port has two fairly serious problems at the moment: RUN_DEPENDS+= ${BUILD_DEPENDS} although not necessarily bad would be better as: RUN_DEPENDS:= ${BUILD_DEPENDS} to avoid sucking in extra RUN_DEPENDS. Also, ${LN} -s ${LOCALBASE}/sbin/mailscanner ${PREFIX}/sbin/MailScanner makes absolutely no sense at all, since ${PREFIX}/sbin/mailscanner is installed in the line above it; if PREFIX!=LOCALBASE that's an error. Also I took the opportunity to remove a stale %%RC_SUBR%% reinplace, and integrated three calls of perl to one call of sed. Fix: - Use PREFIX instead of LOCALBASE for files installed by this port - Remove obsolete %%RC_SUBR%% reference - Use RUN_DEPENDS:= ${BUILD_DEPENDS} to avoid pulling in extras Submitted by: Chris Rees (utisoft@gmail.com) Patch attached with submission follows:
New patch at [1] -- since no-one is set as maintainer, i'd like to grab it please! I've sorted the tangled mess of ${PERL} -pi -e into three REINPLACE_CMDs; easier to maintain when the changes are shared among loads of files. I'll sort out the do-install madness at a later date if that's OK. Perhaps new message could be: - Pass maintainership to submitter - Use PREFIX instead of LOCALBASE for files installed by this port - Remove obsolete %%RC_SUBR%% reference - Use RUN_DEPENDS:= ${BUILD_DEPENDS} to avoid pulling in extras - Use REINPLACE rather than PERL, condense Submitted by: Chris Rees (utisoft@gmail.com) [1] http://www.bayofrum.net/~crees/patches/mailscanner-various.diff
Responsible Changed From-To: freebsd-ports-bugs->sahil Take.
sahil 2011-05-08 20:54:08 UTC FreeBSD ports repository Modified files: mail/mailscanner Makefile Log: - Pass maintainership to submitter - s/LOCALBASE/PREFIX/ where necessary - Remove obsolete %%RC_SUBR%% reference - Assign to RUN_DEPENDS with immediate expansion - Use REINPLACE_CMD instead of PERL macro PR: ports/156883 Submitted by: Chris Rees <utisoft@gmail.com> Revision Changes Path 1.95 +62 -99 ports/mail/mailscanner/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!