Bug 157047 - [Patch] graphics/imlib2 - Wrong LIB_DEPENDS if graphics/giflib is installed
Summary: [Patch] graphics/imlib2 - Wrong LIB_DEPENDS if graphics/giflib is installed
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Stanislav Sedov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-14 21:10 UTC by Herbert J. Skuhra
Modified: 2011-05-15 00:10 UTC (History)
0 users

See Also:


Attachments
file.diff (735 bytes, patch)
2011-05-14 21:10 UTC, Herbert J. Skuhra
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Herbert J. Skuhra 2011-05-14 21:10:09 UTC
If graphics/giflib is installed graphics/imlib2 is linked against libgif.so.5
and not libungif.so.5!

% ls -l /var/db/pkg |grep gif
drwxr-xr-x  2 root  wheel  512 14 mai 21:25 giflib-4.1.6
drwxr-xr-x  2 root  wheel  512 13 mai 16:02 libungif-4.1.4_5

% pwd
/usr/ports/graphics/imlib2

% ldd work/imlib2-1.4.4/src/modules/loaders/.libs/gif.so |grep gif
work/imlib2-1.4.4/src/modules/loaders/.libs/gif.so:
        libgif.so.5 => /usr/local/lib/libgif.so.5 (0x281a4000)

So in this case LIB_DEPENDS is wrong.

Is the attached patch commitable or should we enforce linking against
libungif?

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer 2011-05-14 21:10:21 UTC
Responsible Changed
From-To: freebsd-ports-bugs->stas

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2011-05-15 00:09:55 UTC
stas        2011-05-14 23:09:46 UTC

  FreeBSD ports repository

  Modified files:
    graphics/imlib2      Makefile 
  Log:
  - Imlib picks up giflib if available instead of libungif.  Account for
    this.
  
  PR:             ports/157047
  Submitted by:   "Herbert J. Skuhra" <h.skuhra@gmail.com>
  
  Revision  Changes    Path
  1.141     +6 -1      ports/graphics/imlib2/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Stanislav Sedov freebsd_committer 2011-05-15 00:10:08 UTC
State Changed
From-To: open->closed

Looks good!  Thanks!