Bug 157433 - [PATCH] un-break audio/rezound for 64 bit
Summary: [PATCH] un-break audio/rezound for 64 bit
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-30 19:00 UTC by lgfbsd
Modified: 2011-07-24 13:40 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (4.54 KB, patch)
2011-05-30 19:00 UTC, lgfbsd
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description lgfbsd 2011-05-30 19:00:28 UTC
	

The "rezound" port has been broken for a while on amd64 and sparc64
because of a bunch of "pointer can fit in an integer" assumptions.  I
checked that in each case, the data in the pointer had come from an
integer in the first place, so a quick and easy hack will get it
rolling again.  I didn't try to come up with clean solutions, because
I wasn't sure they would work on other platforms.  For that matter, I
didn't test the sparc64 case.

How-To-Repeat: 
From port's makefile:

.if ${OSVERSION} >= 700042
.if ${ARCH} == "amd64" || ${ARCH} == "sparc64"
BROKEN=		Does not compile with GCC 4.2
.endif
.endif
Comment 1 Edwin Groothuis freebsd_committer 2011-05-30 19:00:39 UTC
Responsible Changed
From-To: freebsd-ports-bugs->danfe

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2011-07-24 13:32:22 UTC
danfe       2011-07-24 12:32:09 UTC

  FreeBSD ports repository

  Modified files:
    audio/rezound        Makefile 
  Added files:
    audio/rezound/files  patch-64bit-fixes patch-fix-raw-save 
  Log:
  - Add a patch to fix the build on 64-bit arches (patch in the PR looks like
    it originated from Gentoo, which in turn says it's copyrighted by T2 SDE
    Project and submitted by Rene Rebe; committed version should be more clean
    and correct) [*]
  - Add a patch from Christian Schoenebeck to fix saving of raw files (Debian
    bug id 602277, Gentoo's 203471)
  - Fix a typo in #ifndef directive (also obtained from Gentoo)
  - Fix GNU gettext detection in configure script (was not 64-bit clean, thus
    package for e.g. amd64 would not pack because of broken pkg-plist)
  - Bump port revision after recent changes in dependencies and bugfixes
  
  PR:             ports/157433 [*]
  Submitted by:   Lowell Gilbert
  
  Revision  Changes    Path
  1.27      +5 -9      ports/audio/rezound/Makefile
  1.1       +78 -0     ports/audio/rezound/files/patch-64bit-fixes (new)
  1.1       +78 -0     ports/audio/rezound/files/patch-fix-raw-save (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Alexey Dokuchaev freebsd_committer 2011-07-24 13:36:09 UTC
State Changed
From-To: open->closed

Slightly different version committed, along with other fixes, thanks!