Bug 157748 - calendar(1): Patch for src/usr.bin/calendar/calendars/calendar.holiday
Summary: calendar(1): Patch for src/usr.bin/calendar/calendars/calendar.holiday
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 8.2-RELEASE
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-11 01:50 UTC by jhs
Modified: 2017-12-31 22:32 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (32.55 KB, patch)
2011-06-11 01:50 UTC, jhs
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jhs 2011-06-11 01:50:07 UTC
Whilst writing /usr/share/calendar/calendar.british
( sumitted as gnats misc/157466
  http://www.freebsd.org/cgi/query-pr.cgi?pr=157466 
) , then improved since (URL for improved version in that send-pr)
I found that  src/usr.bin/calendar/calendars/calendar.holiday
was a Real mess, Many wrong dates, junk that didnt belong etc.

Fix: Please apply the diff.
Then go through & delete my comments some of which are specifically
for the info of the commiter.
information

Some of the diffs assume my gnats misc/157466 will be commited first,
which will create
	src/usr.bin/calendar/calendars/calendar.british
	src/usr.bin/calendar/calendars/en_UK.ISO8859-1/
but if misc/157466 hasnt been commited yet, no need to wait, 
as each patch ndividually makes clear if it needs the above.
Lots of dead simple things to fix,
Examples:
- Britains dates - some are Wrong.
- Yugoslavia's national holiday - the country doesn't exist !
  	delete or move it from <calendar.holiday> to <calendar.history>.
- Saints days that are not holidays -
	move from <calendar.holiday> to <calendar.christian>
	

	

A copy of my diff -c appended.

Newest copy at
http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/calendar/calendars/calendar.holiday.REL=ALL.diff

http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/calendar/calendars/calendar.holiday.REL=ALL.diff
Filed by
http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/calendar/calendars/calendar.holiday.send-pr.ignore

See also
http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/calendar/calendars/calendar.british
&
http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/calendar/send-pr.calendar.ignore
How-To-Repeat: 	
Read my diff, I have put as comments what is wrong.
Comment 1 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 07:58:43 UTC
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped